Improve vector source clear() performance #3013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three seconds speed up for clearing 100'000 features.
Three seconds speed up when clearing 100'000 features. Clearing is now around 350ms.
|
This is a significant improvement! We need to have this. The only problem is that it may break applications that expect a One option is to add an |
|
@elemoine, I added the |
| @@ -37,7 +37,15 @@ ol.source.VectorEventType = { | |||
| CHANGEFEATURE: 'changefeature', | |||
|
|
|||
| /** | |||
| * Triggered when a clear is called on the source. | |||
There was a problem hiding this comment.
-> Triggered when the clear function is called on the source.
|
Minor comments, otherwise looks very good to me! |
gberaudo
force-pushed
the
performance_vector_source_clear
branch
from
85a0538 to
e3947fb
Compare
|
LGTM. |
|
@elemoine, please merge. |
elemoine
pushed a commit
that referenced
this pull request
Dec 8, 2014
Improve vector source clear() performance
|
Thanks for updating the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up from 8 seconds to 350ms the clearing of 100'000 features.
This 24 times improvement is in part gained by dispatching a single
clearevent in spite of sending aremovefeatureevent for each of the 100'000` features.