Simplify hit detection code #3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huge improvement. Thanks for doing this! Please merge. |
|
Hm. I spoke too soon. This conflicts with #3010 and makes it much harder if not impossible to achieve what I want there. |
|
No sorry, please disregard my previous comment. Everything is fine 😄. |
|
I'd have been surprised. This PR does not change any logic I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a major refactoring of the replay hit detection code, to simplify the code.
Previously the replay objects did not know about features, and they manipulated opaque
dataobjects instead. This was true until we introduced theskippedFeatureHash.This PR clarifies the situation by removing the opaque
dataobject. The replay objects now know about features, which simplifies and clarifies the code.