Use writeFeatures instead of writeFeaturesNode in GPX and KML example

[bartvde]

This was pointed out by @tschaub in #3003 (comment) and #3003 (comment)

[elemoine]

Looks good to me. Please merge when the build is fixed.

[bartvde]

right wondering now why the build thinks writeFeatures returns a Node or null ... ;-)

[bartvde]

ah I see it now, missed an annotation in the source code

[elemoine]

I think there is a problem in gpx.js: writeFeatures does not have the correct signature.

[bartvde]

right I just spotted the same @elemoine will fix

[elemoine]

Again, please merge when the build is fixed. Thanks Bart. And thanks Closure Compiler. Believe it or not, I now love CC.

[bartvde]

it definitely helps, only a shame it was only spotted when using the code in the example ;-)

[elemoine]

it definitely helps, only a shame it was only spotted when using the code in the example ;-)

We're talking about the return type of an API function that is to be used by applications. So it makes sense that the compiler catches this when compiling the examples. This is also why compiling the examples is actually a good thing.

[bartvde]

yes I get that, I just wished the normal build step would catch this without having to use all the api code in an example but I'm probably not overseeing whether this is possible at all

Sent from my iPhone

On 7 dec. 2014, at 18:21, Éric Lemoine [email protected] wrote:

it definitely helps, only a shame it was only spotted when using the code in the example ;-)

We're talking about the return type of an API function that is to be used by applications. So it makes sense that the compiler catches this when compiling the examples. This is also why compiling the examples is actually a good thing.

—
Reply to this email directly or view it on GitHub.

[elemoine]

yes I get that, I just wished the normal build step would catch this without having to use all the api code in an example but I'm probably not overseeing whether this is possible at all

Certainly not what you're thinking about but we could have the check target compile the examples code (build/examples/all.combined.js really) at least.