popup example cleanup / simplification #3096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,10 +10,8 @@ | |||
| <link rel="stylesheet" href="../resources/bootstrap/css/bootstrap-responsive.min.css" type="text/css"> | |||
| <style type="text/css"> | |||
| .ol-popup { | |||
| display: none; | |||
There was a problem hiding this comment.
I haven't checked your branch, but do you get a flash of popup content if display is not none on load?
There was a problem hiding this comment.
The popup is not visible on load because its position is absolute with a bottom value of 15px: the element is shifted to the bottom of the page. This can be improved by storing the div in an invisible container (https://github.com/openlayers/ol3/blob/master/examples/overlay.html#L68-L74)
Gecko 13 (Firefox 13) removed support for -moz-box-shadow. Since then, only the unprefixed version is supported.
|
Looks like a good simplification. Please merge. |
|
LGTM too. Thanks @fredj. |
fredj
added a commit
that referenced
this pull request
Jan 8, 2015
popup example cleanup / simplification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.