Don't pass specific options to the parent constructor

[fredj]

Same as #3104

[elemoine]

You could probably do it w/o cloning the options object:

ol.layer.Tile = function(opt_options) {
  var options = goog.isDef(opt_options) ? opt_options : {};

  var preload = goog.isDef(options.preload) ? options.preload : 0;
  var useInterimTilesOnError = goog.isDef(options.useInterimTilesOnError) ?
      options.useInterimTilesOnError : true;

  delete options.preload;
  delete options.useInterimTilesOnError;

  goog.base(this, /** @type {olx.layer.LayerOptions} */ (options));

  this.setPreload(preload);
  this.setUseInterimTilesOnError(useInterimTilesOnError);
};

(untested)

[fredj]

+1

[fredj]

You code works but I suggest to keep the goog.object.clone: it is how it's done in the other classes (ol.layer.Group, ol.layer.Vector, ...) and we will had to change if if/when we have a new non primitive type to handle.

[elemoine]

You code works but I suggest to keep the goog.object.clone: it is how it's done in the other classes (ol.layer.Group, ol.layer.Vector, ...)

Ok.

and we will had to change if if/when we have a new non primitive type to handle.

We'd need to add delete statements anyway, even if clone is used. No?

[fredj]

We'd need to add delete statements anyway, even if clone is used. No?

Correct.

I thought that deleting a non primitive type from an object will delete the copy too:

var obj = {
  arr: [1,2,3]
};
var c = obj.arr;
delete obj.arr;

Unlike what I was thinking: c == [1,2,3]

[elemoine]

delete just removes the property from an object. It does nothing to the object that property refers to.

[fredj]

@elemoine do you agree to merge this PR as it?

[elemoine]

Yep. Please merge.