Bugfix: "Cannot read property 'firstElementChild' of null" (WFS)

[brianreavis]

Occurs when the WFS FeatureCollection is empty.

[bartvde]

hey @brianreavis thanks for this, can you please add a testcase and format the code according to the guidelines, e.g. always { for if else. Also a code block is duplicated in your PR:

node = node.firstElementChild;
+  if (!goog.isDefAndNotNull(node)) return null;

[elemoine]

Too bad this is not enforced by the linter. Maybe there is an option we can pass to jshint.

[brianreavis]

@bartvde Yeah, I can add in the brackets. The code block is intentionally duplicated:

// original line:
node = node.firstElementChild.firstElementChild;

// expanded form:
node = node.firstElementChild;
node = node.firstElementChild;

[bartvde]

ah okay I'd use || in that case (and a single if statement) for more code clarity

[bartvde]

or protect the for loop with:

if (goog.isDefAndNotNull(node.firstElementChild) && goog.isDefAndNotNull(node.firstElementChild.firstElementChild)) {

[brianreavis]

@bartvde @elemoine Okay, this should be good to go now

[bartvde]

thanks @brianreavis last step would be to clean up the git history with a git rebase, are you familiar with that?

[brianreavis]

Done. Does OL have any plans on relaxing the style? The strictness (line length in particular) is making code readability and contribution a mess.

[bartvde]

@brianreavis have you submitted a CLA already? https://github.com/openlayers/ol3/blob/master/CONTRIBUTING.md#contributor-license-agreement

[brianreavis]

Done...

[bartvde]

thanks for your contribution and patience @brianreavis

[elemoine]

Done. Does OL have any plans on relaxing the style?

I'd say that we're pretty happy with what we use :-)