Make changing the label of ZoomToExtent/FullScreen control consistent #3135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,13 +36,33 @@ ol.control.FullScreen = function(opt_options) { | |||
| this.cssClassName_ = goog.isDef(options.className) ? | |||
| options.className : 'ol-full-screen'; | |||
|
|
|||
| var label = goog.isDef(options.label) ? | |||
| options.label : '\u2194'; | |||
There was a problem hiding this comment.
Super super minor: you could probably use one line instead of two here.
tsauerwein
force-pushed
the
control-label
branch
from
c021fed to
7679069
Compare
|
This looks great to me. Thanks a lot for making this consistent across all the controls! Please merge. |
tsauerwein
pushed a commit
that referenced
this pull request
Jan 29, 2015
Make changing the label of ZoomToExtent/FullScreen control consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the label for the controls
ZoomToExtentandFullScreenis set via a:afterstyle in CSS. To change the label, you would have to overwrite that CSS style. To be consistent with the other controls, I added alabelproperty to the options.Now, also the following would be possible to use the Bootstrap Glyphicons: