Add ol.control.Control#setTarget

[elemoine]

This commit adds a setTarget method to ol.control.Control. This function can be used in cases where the target cannot be set at control construction time.

For example, with Angular, it makes sense to create the control instance in an Angular controller, and have a "control" directive insert the control into the DOM.

[ahocevar]

I think this is a limitation which is not necessary. With a little more code, you could use setTarget to move the control's markup around in the document. Or am I missing something?

[elemoine]

It actually gets much more complex if you go that path so I decided to go the simple way.

[ahocevar]

What about

ol.control.Control.prototype.setTarget = function(target) {
  var map = this.map_;
  this.setMap(null);
  this.target_ = target;
  this.setMap(map);
};

If that does not work, you could at least add an assertion to ensure that the map is not set yet.

[elemoine]

That may work but it's also three setMap calls if you add the control to the map and then calls setTarget. This will also add the control element to the map overlay container to finally remove it to add it to the final target. Not so nice I think.

[tschaub]

It may also be important to maintain the control's position in the collection (meaning it might be unexpected to have it jump to the end of the collection when you call setTarget).

I imagine most people will expect setTarget to work when called more than once. But I wouldn't be opposed to adding the method as is and then making it more useful later.

[ahocevar]

Agreed. Looks like a major effort indeed.

[elemoine]

It may also be important to maintain the control's position in the collection (meaning it might be unexpected to have it jump to the end of the collection when you call setTarget).

setMap is called when a control is added to or removed from a map's controls collection, but calling setMap directly does not change the collection. So that part is not an issue.

[elemoine]

Thanks for the reviews. I changed the docs as suggested by @tschaub. I'll merge this if there are no other comments.

[elemoine]

@ahocevar do you agree with merging this?

[ahocevar]

Sure, please merge!

[elemoine]

Thanks. I just wanted to make sure.