Use view.getRotation or view.getResolution instead of view.getState

[fredj]

getState() returns all the view properties; no need to call it when only one property is used.

[bartvde]

LGTM

[elemoine]

getState().rotation is 0 if the rotation is undefined in the view, while getRotation returns undefined in that case. So I don't think that change is totally correct.

[bartvde]

@elemoine but doesn't the constructor set the rotation to 0 in that case? It seems to me a lot of the current code in ol.View does not handle an undefined rotation anyway?

  properties[ol.ViewProperty.ROTATION] =
      goog.isDef(options.rotation) ? options.rotation : 0;

[elemoine]

Yes, but look at setRotation and getRotation. undefined is a possible value.

[bartvde]

true, but do you agree there is a lot of code in ol.View that doesn't handle the undefined case correctly? Should we not just disallow undefined for rotation?

[fredj]

I also think that undefined should be disallowed for rotation; the only way to have undefined is to call view.setRotation(undefined);

[fredj]

What about https://github.com/fredj/ol3/compare/undefined-rotation ?

[bartvde]

this makes sense to me @fredj
@elemoine ?

[fredj]

And we could do the same for others properties, eg. ol.layer.Base#visible, ol.layer.Base#opacity, ...

[gberaudo]

I agree: it would greatly diminish code complexity.