Allow other params than 'mode' in example page query string. #3183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if other params are present at the beginning of the query string, the mode switcher will not work. This situation can occur when a search criteria was entered in the examples index page. That criteria will be passed along to the example page via a query param.
This was referenced Jan 27, 2015
|
Looks good. Thanks! |
elemoine
pushed a commit
that referenced
this pull request
Jan 28, 2015
Allow other params than 'mode' in example page query string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix to #3184
Other fix: #3182
Currently, if other params are present at the beginning of the query string of an example page, the mode switcher will not work.
This situation can occur when a search criteria was entered in the examples
index page. That criteria will be passed along to the example page via a query
param.
Eg: http://openlayers.org/en/v3.1.1/examples/simple.html?q=simpl