Allow reuse of layer rendering code without creating a map #3215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an effort to make the layer rendering code a bit more reusable. For the most part, layer rendering methods are provided what they need in the frame state, and they do not need access to a map or a map renderer.
Previously, the layer renderer's image loading handler would call
map.render()
directly. Now layer renderers are observable and they fire a change event on image load (if otherwise ready).The WebGL layer renderers can be refactored to be given an
ol.webgl.Context
instead of a map renderer. This would replace all calls tomapRenderer.getContext()
andmapRenderer.getGL()
within the layer renderers. However, the WebGL tile layer renderer is still tied to the map renderer through its use of the tile texture queue and cache. If someone was motivated to change this, the tile renderer could be passed the queue and cache instead of maintaining a reference to the map renderer to access them. Until then the WebGL layer renderers are a special case in that they need a reference to a map renderer.