-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add tile loading events to image tile sources #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Here's the example demonstrating a simple progress bar monitoring tile loading for a single source: |
This looks like a solid piece of much welcome work @tschaub the only remark I have is a typo in one of the commit messages (Uregister -> Unregister) |
Thanks for the review @bartvde. I reworded that commit message. Will merge when Travis goes green. |
Add tile loading events to image tile sources.
Now that we register an additional listener for tile events, it will be nice to avoid creating tiles that are not needed. These listeners aren't unregistered until the tile cache for a source is full. See #3246 for a change that avoids unnecessary tile creation. |
hey @tschaub forgot to ask, but do you have plans to add events for image sources as well or not? If not, I can probably take a crack at it. |
@bartvde yes - I'd like to do the same. But I'm not working on it currently, so it would be great if you wanted to take it on. If I do find some time for it, I'll open a ticket first to indicate that I'm working on it. |
Nice work @tschaub. |
This adds
tileloadstart
,tileloadend
, andtileloaderror
type events to tile sources.