Skip to content

Add tile loading events to image tile sources #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 18, 2015
Merged

Add tile loading events to image tile sources #3248

merged 6 commits into from
Feb 18, 2015

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Feb 16, 2015

This adds tileloadstart, tileloadend, and tileloaderror type events to tile sources.

@tschaub tschaub changed the title (WIP) Add tile loading events to image tile sources Add tile loading events to image tile sources Feb 17, 2015
@tschaub
Copy link
Member Author

tschaub commented Feb 17, 2015

Here's the example demonstrating a simple progress bar monitoring tile loading for a single source:
http://tschaub.net/ol-tile-load-events/examples/tile-load-events.html

@bartvde
Copy link
Member

bartvde commented Feb 18, 2015

This looks like a solid piece of much welcome work @tschaub
LGTM

the only remark I have is a typo in one of the commit messages (Uregister -> Unregister)

@tschaub
Copy link
Member Author

tschaub commented Feb 18, 2015

Thanks for the review @bartvde. I reworded that commit message. Will merge when Travis goes green.

tschaub added a commit that referenced this pull request Feb 18, 2015
Add tile loading events to image tile sources.
@tschaub tschaub merged commit b8e3deb into openlayers:master Feb 18, 2015
@tschaub tschaub deleted the tile-events branch February 18, 2015 23:16
@tschaub
Copy link
Member Author

tschaub commented Feb 18, 2015

Now that we register an additional listener for tile events, it will be nice to avoid creating tiles that are not needed. These listeners aren't unregistered until the tile cache for a source is full. See #3246 for a change that avoids unnecessary tile creation.

@bartvde
Copy link
Member

bartvde commented Feb 20, 2015

hey @tschaub forgot to ask, but do you have plans to add events for image sources as well or not? If not, I can probably take a crack at it.

@tschaub
Copy link
Member Author

tschaub commented Feb 20, 2015

@bartvde yes - I'd like to do the same. But I'm not working on it currently, so it would be great if you wanted to take it on. If I do find some time for it, I'll open a ticket first to indicate that I'm working on it.

@elemoine
Copy link
Member

Nice work @tschaub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants