-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Make package.json compatible for npm frontend use #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR augments package.json to ease OpenLayers 3 frontend development through NPM. See this post on NPM blog http://blog.npmjs.org/post/112712169830/making-your-jquery-plugin-work-better-with-npm to understand my viewpoint and evaluate if it's worth to accept.
Can you provide an example of something you can do after this change (but not before)? |
See PR comments for an update
I've updated my PR. A bit ashamed... |
When pushing previous content to npm, it complains that it only accepts `"browser": "dist/ol.js"` hence the correction again
I have no problem with that change. @tschaub? |
https://www.npmjs.com/package/parcelify does not seem to be that popular. What do you think @tschaub? |
This looks ok by me. Thanks @ThomasG77. |
Make package.json compatible for npm frontend use.
this breaks tools like dr-frankenstyle (https://www.npmjs.com/package/dr-frankenstyle used by Pivotal UI React) where style needs to be a string not an array:
|
I guess I can whitelist the directories though to have it ignore the openlayers directory |
This PR augments package.json to ease OpenLayers 3 frontend development through NPM.
See this post on NPM blog to get more informations and evaluate if it's worth to accept.
If you use Browserify and/or Parcelify, you can use this informations out of the box.
browser
part is in this specIt's up to you to decide if providing paths to js and css is good.
In fact, it's quite similar to Bower but we don't create a new file, we only use existing
package.json
.