Skip to content

Add flight animation example #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2015

Conversation

tsauerwein
Copy link
Member

One more example demonstrating the use of postcompose.

flight-animation
http://tsauerwein.github.io/ol3/animation-flights/examples/flight-animation.html

@elemoine
Copy link
Member

The build fails:

info ol Parsing dependencies

info ol Compiling 358 sources

ERR! compile /home/travis/build/openlayers/ol3/build/compiled-examples/all.js:2207: ERROR - 'arc.GreatCircle' used but not goog.require'd

ERR! compile         var arcGenerator = new arc.GreatCircle(

ERR! compile                            ^

ERR! compile 

ERR! compile 

ERR! compile 1 error(s), 0 warning(s)

ERR! compile 

ERR! Process exited with non-zero status, see log for more detail: 1 

make: *** [build/compiled-examples/all.combined.js] Error 1

which makes sense as we don't have externs for the arc library.

Two options: (a) create an externs file for the arc library, (b) add // NOCOMPILE as the first line of the flight-animation.js file.

+1 for option (a).

@tschaub
Copy link
Member

tschaub commented Nov 11, 2015

@tsauerwein can you update this with // NOCOMPILE? Having externs files for things only used in the examples seems like overkill to me. But I know we already do this.

@tsauerwein
Copy link
Member Author

Thanks for the reminder, I rebased and added NOCOMPILE.

@tsauerwein
Copy link
Member Author

I will update the example once #4401 is merged.

@tsauerwein
Copy link
Member Author

PR updated, a review would be appreciated! :)

@fredj
Copy link
Member

fredj commented Nov 16, 2015

LGTM

}
}
// tell OL3 to continue the postcompose animation
frameState.animate = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having people mutate the frame state, I think we should encourage the use of map.render() (this is part of the documented API).

@tsauerwein
Copy link
Member Author

Thanks for the feedback, merging.

tsauerwein pushed a commit that referenced this pull request Nov 17, 2015
@tsauerwein tsauerwein merged commit 440a8bd into openlayers:master Nov 17, 2015
@tsauerwein tsauerwein deleted the animation-flights branch November 17, 2015 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants