-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add flight animation example #4140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build fails:
which makes sense as we don't have externs for the Two options: (a) create an externs file for the +1 for option (a). |
@tsauerwein can you update this with |
8fb68f0
to
232126f
Compare
Thanks for the reminder, I rebased and added |
I will update the example once #4401 is merged. |
232126f
to
04567dd
Compare
PR updated, a review would be appreciated! :) |
LGTM |
} | ||
} | ||
// tell OL3 to continue the postcompose animation | ||
frameState.animate = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having people mutate the frame state, I think we should encourage the use of map.render()
(this is part of the documented API).
de1bb48
to
faf9e46
Compare
Thanks for the feedback, merging. |
Add flight animation example
One more example demonstrating the use of
postcompose
.http://tsauerwein.github.io/ol3/animation-flights/examples/flight-animation.html