Skip to content

Fixes for building with Node 4.x #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2015
Merged

Fixes for building with Node 4.x #4163

merged 1 commit into from
Oct 31, 2015

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Sep 23, 2015

The generate-info.js task fails on Node 4.x because process.stdout.write() is now async, and our exit handler is called before the child JSDoc task's publish method finishes writing to stdout.

Because the generate-info.js task fails, the build.js task does as well.

It would be nice to use a published version of JSDoc. I'll ask when the next version might be published. I think this is a big enough issue that we should merge a fix before 3.10 is released - even if it means going with an unpublished version of JSDoc. I also need to confirm that the API doc output is still good.

Fixes #4127.

@probins
Copy link
Contributor

probins commented Sep 25, 2015

Promises are natively supported in Node 4. You probably don't need bluebird here.

@ahocevar
Copy link
Member

ahocevar commented Oct 6, 2015

Looks great @tschaub, please merge.

@probins I think for now it makes sense to still support older versions of node, so using bluebird should be fine.

@fredj
Copy link
Member

fredj commented Oct 6, 2015

Can we use jsdoc version 3.3.3?

@ahocevar ahocevar added this to the v3.11.0 milestone Oct 8, 2015
@tschaub
Copy link
Member Author

tschaub commented Oct 12, 2015

Can we use jsdoc version 3.3.3?

See jsdoc/jsdoc#1070. We need this commit: jsdoc/jsdoc@7d9fc7b (which is not in a published release yet).

The change we need is included in jsdoc/jsdoc@bd1cb9d. Which is understandably the source of a lot of confusion.

@tschaub tschaub closed this Oct 30, 2015
@tschaub tschaub reopened this Oct 30, 2015
@tschaub
Copy link
Member Author

tschaub commented Oct 30, 2015

I've published a forked version of jsdoc. I don't intend to maintain this fork, but I'd very much like to get our builds working with both Node 4 and npm 3. The master branch of jsdoc has the changes we need for Node 4 (the changes in jsdoc/jsdoc#1082 would make this even better). If a new version is published with these changes, we can switch back.

@tschaub
Copy link
Member Author

tschaub commented Oct 31, 2015

Note that when/if there is a jsdoc version published that works with Node 4, we need to replace all jsdoc-fork in our source with jsdoc.

tschaub added a commit that referenced this pull request Oct 31, 2015
Fixes for building with Node 4.x.
@tschaub tschaub merged commit 9529200 into openlayers:master Oct 31, 2015
@tschaub tschaub deleted the node-four branch October 31, 2015 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom build fails with Node 4.0
4 participants