Fixes for building with Node 4.x #4163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generate-info.js
task fails on Node 4.x becauseprocess.stdout.write()
is now async, and our exit handler is called before the child JSDoc task's publish method finishes writing to stdout.Because the
generate-info.js
task fails, thebuild.js
task does as well.It would be nice to use a published version of JSDoc. I'll ask when the next version might be published. I think this is a big enough issue that we should merge a fix before 3.10 is released - even if it means going with an unpublished version of JSDoc. I also need to confirm that the API doc output is still good.
Fixes #4127.