Render name labels if the geometry is a point in KML format (@tamarmot) #4316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjansen
changed the title
marcjansen
added a commit
that referenced
this pull request
Oct 25, 2015
Render name labels if the geometry is a point in KML format (@tamarmot)
| } | ||
| if (!goog.object.isEmpty(foundStyle.getText())) { | ||
| textStyle = /** @type {ol.style.Text} */ | ||
| (goog.object.clone(foundStyle.getText())); |
There was a problem hiding this comment.
The use of goog.object.isEmpty() and goog.object.clone() should be avoided here. See #4781.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #4306. With a fixed build (
gjslintfailed) and a corrected color. I also changes the commit messages to be more in line with our recommendations.Thanks for the continued work on this, @tamarmot