Skip to content

Use ratio when calculating ImageWMS width and height #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2015

Conversation

ahocevar
Copy link
Member

Fixes #4403.

@tschaub
Copy link
Member

tschaub commented Nov 12, 2015

This looks like it corrects the single image WMS example (on a non-retina device at least). It would be great to get in a regression test for this, but I think a patch release is more urgent.

Thanks for the fix. Please merge.

@ahocevar
Copy link
Member Author

I was planning to add tests for this anyway, but decided to look into #4405, the other serious regression, first.

ahocevar added a commit that referenced this pull request Nov 12, 2015
Use ratio when calculating ImageWMS width and height
@ahocevar ahocevar merged commit 14338e9 into openlayers:v3.11.x Nov 12, 2015
@ahocevar ahocevar deleted the fix-imagewms-ratio-3.11.x branch November 12, 2015 17:30
@ahocevar
Copy link
Member Author

BTW, fixed for Retina displays too.

@tschaub
Copy link
Member

tschaub commented Nov 12, 2015

Thanks @ahocevar.

The downside of using a branch as the base for patches is that the continuous-integration/travis-ci/pr job doesn't run. I just pushed a change to our Travis config to make the continuous-integration/travis/push job run for branches named like /^v.*\.x$/. Not as convenient since we don't get the commit status updated on a PR. But we can check the build status periodically (e.g. https://travis-ci.org/openlayers/ol3/builds/90780614).

The alternative is to commit patches to master and then cherry-pick. But that brings potential for conflicts.

Update - as an alternative to triggering the Travis push job for branches named like v.X.Y.x, I've just opened a pull request for this branch (see #4410). There we can watch the commit status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants