Skip to content

Adding a check just in case the projection is not defined/supported #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2015

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Dec 2, 2015

Adding a check just in case the projection is not defined/supported on current app. It will just ignore it, as if there was no containerSrs defined.

On the current implementation, an exception is thrown, making it difficult, for example, to get a featureinfo request right.

…n current app. It will just ignore it, as if there was no containerSrs defined.
@bartvde
Copy link
Member

bartvde commented Dec 2, 2015

thanks @Delawen do we have a (I)CLA from you?

@Delawen
Copy link
Contributor Author

Delawen commented Dec 2, 2015

I think I sent it a long time ago, but just to be sure I will fill it again.

@bartvde
Copy link
Member

bartvde commented Dec 2, 2015

Right seems to be missing from the list: https://github.com/openlayers/cla/blob/master/signed-agreements.md

@Delawen
Copy link
Contributor Author

Delawen commented Dec 2, 2015

Just sent it by the google form.

@bartvde
Copy link
Member

bartvde commented Dec 2, 2015

thanks!

bartvde added a commit that referenced this pull request Dec 2, 2015
Adding a check just in case the projection is not defined/supported
@bartvde bartvde merged commit 612aa34 into openlayers:master Dec 2, 2015
@bartvde
Copy link
Member

bartvde commented Dec 2, 2015

@Delawen for your next PR, you might consider splitting long commit messages into summary and paragraph as per: https://github.com/openlayers/ol3/blob/master/CONTRIBUTING.md#use-clear-commit-messages

@Delawen
Copy link
Contributor Author

Delawen commented Dec 2, 2015

Will do it. Thanks for the quick response!

@pvgenuchten
Copy link

some background info is that a featureinfo on data.rivm.nl/geoserver/wms fails due to geometry in featureinfo-gml is in local projection (epsg:28992) and the epsg:28992 projection definition is not available in the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants