Add example for rendering custom point symbols #4524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
custom-symbols
branch
from
e4247ef to
de3c5b0
Compare
|
This is now fully functional and ready for review. |
| var style = styleCache[size]; | ||
| if (!style) { | ||
| var canvas = document.createElement('canvas'); | ||
| canvas['width'] = size + 2; |
There was a problem hiding this comment.
this is not needed anymore right, will be done by the toContext function?
There was a problem hiding this comment.
Exactly. Thanks for spotting this. Fixed.
ahocevar
force-pushed
the
custom-symbols
branch
2 times, most recently
from
bf1a28d to
a9ebcde
Compare
|
LGTM |
ahocevar
force-pushed
the
custom-symbols
branch
from
a9ebcde to
ca79fa1
Compare
ahocevar
force-pushed
the
custom-symbols
branch
from
ca79fa1 to
0050f00
Compare
ahocevar
added a commit
that referenced
this pull request
Dec 7, 2015
Add example for rendering custom point symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example shows another use of
ol.render.toContext.It will be fully functional when both #4523 and #4515 are merged.