Handle tile coordinate wrapping when reprojecting raster tiles #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exactly the right fix. Thanks @petrsloup, please merge. |
petrsloup
force-pushed
the
rasterreproj-wrapx
branch
from
78407f9 to
9f5d85f
Compare
petrsloup
added a commit
that referenced
this pull request
Dec 11, 2015
Handle tile coordinate wrapping when reprojecting raster tiles
|
@ahocevar Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling of wrapX to the tile reprojection process.
This way, when reprojecting for example
EPSG:3857toEPSG:4326the map is "repeated", because the default TileGrid forEPSG:4326(ol.tilegrid.createForProjection('EPSG:4326')) has wrapX enabled.Internally, this uses
ol.source.Tile#getTileCoordForTileUrlFunctionto handle the wrapping.Fixes #4447
@ahocevar I believe you did a lot of work on the wrapX feature. Can you please take a look if this is indeed the right way of handling this?