Skip to content

Exclude feature loader MVT test from IE9 #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Exclude feature loader MVT test from IE9 #4561

merged 1 commit into from
Dec 15, 2015

Conversation

bartvde
Copy link
Member

@bartvde bartvde commented Dec 15, 2015

closes #4560

@bartvde bartvde added this to the v3.12.0 milestone Dec 15, 2015
@ahocevar
Copy link
Member

Instead of

describe('foo', function() {
  beforeEach(function() {
    // setup
  });
  it('bar', function() {
    // the only test in this describe block
  })
});

it would be nicer to do

it('foo bar', function() {
  // setup
  // the only test in this describe block
});

Would make the tests easier to read, and you can do xit instead of xdescribe.

@bartvde
Copy link
Member Author

bartvde commented Dec 15, 2015

agreed, will make the change

@ahocevar
Copy link
Member

Looks good now. Please merge when Travis has finished their review.

bartvde added a commit that referenced this pull request Dec 15, 2015
Exclude feature loader MVT test from IE9
@bartvde bartvde merged commit 69c44e5 into openlayers:master Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature loader test case fails in IE9
2 participants