Add missing return type to GeoJSON format #4617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM please merge if Travis agrees |
gberaudo
force-pushed
the
type_geojson_writeFeatureObject
branch
from
a0c587b to
f45765f
Compare
gberaudo
force-pushed
the
type_geojson_writeFeatureObject
branch
from
f45765f to
a1c72d8
Compare
|
Thank you for the quick review @bartvde. |
|
Ah sorry I forgot, will merge. Thanks. |
bartvde
added a commit
that referenced
this pull request
Jan 5, 2016
Add missing return type to GeoJSON format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionnally, use dot operator now that the code is typed.