Make sure icons show up in Safari #4659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context.drawImage(image, originX, originY, width, height, | ||
| x, y, width * pixelRatio, height * pixelRatio); | ||
| var w = (width + originX > image.width) ? image.width - originX : width; | ||
| var h = (height + originY > image.height) ? image.height - originY : height; |
There was a problem hiding this comment.
Extra space here: height + originY
There was a problem hiding this comment.
that's what I get for copy paste from Slack ;-)
not caught by make check btw
|
Thanks for the additional rendering tests. Only one minor comment above. Please merge when Travis is happy. |
Make sure that drawImage calls don't exceed source image dimensions.
bartvde
added a commit
that referenced
this pull request
Jan 12, 2016
Make sure icons show up in Safari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that drawImage calls don't exceed source image dimensions.
Fixed #4337 thanks to @ahocevar for his help on this one.