Make tile loading count no longer depend on source count #4794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcjansen, you may want to test this in one of your applications with many tile layers. |
|
I am mostly offline, maybe @weskamm may give this a try |
|
ping @marcjansen |
|
Sorry I won't have time to review. |
|
i also dont have time to test this, sorry |
|
This is a change that only affects applications with multiple tile layers. For two layers, like in the Anyone else up for a review? |
|
LGTM |
|
Thanks @fredj. |
ahocevar
added a commit
that referenced
this pull request
Feb 16, 2016
Make tile loading count no longer depend on source count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the tile queue behaviour so the number of loading tiles is no longer influenced by the number of sources that request tiles. This should give better user experience in applications with many tile layers.
Fixes #4790.