Make sure window.proj4 is always restored in tests #4830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
changed the title
ahocevar
force-pushed
the
proj4-tests
branch
from
f568351 to
27908ed
Compare
|
good catch, LGTM |
|
+1 |
ahocevar
added a commit
that referenced
this pull request
Feb 15, 2016
Make sure window.proj4 is always restored in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the OpenLayers test suite is used with a custom build of proj4.js that does not include the
somercprojection, it fails with the very misleading errorUncaught ReferenceError: proj4 is not defined. This is because the 'can use an alternative namespace for proj4' test fails and does not restorewindow.proj4. See proj4js/proj4js#170 for a more background.By restoring
window.proj4in anafterEachfunction, we can avoid this misleading error.