add rule cardinality check UT

Signed-off-by: Kaushal Kumar <[email protected]>

Author: kaushalmahi12

modules/autotagging-commons/common/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java

@@ -111,24 +111,17 @@ public void createRule(CreateRuleRequest request, ActionListener<CreateRuleRespo
     }
 
     private void performCardinalityCheck(ActionListener<CreateRuleResponse> listener) {
-        client.prepareSearch(indexName).setQuery(queryBuilder.getCardinalityQuery())
-            .execute(new ActionListener<SearchResponse>() {
-                @Override
-                public void onResponse(SearchResponse searchResponse) {
-                    if (searchResponse.getHits().getTotalHits().value() >= MAX_ALLOWED_RULE_COUNT) {
-                        listener.onFailure(
-                            new OpenSearchRejectedExecutionException("This create operation will violate" +
-                                " the cardinality limit of " + MAX_ALLOWED_RULE_COUNT +
-                                ". Please delete some stale or redundant rules first")
-                        );
-                    }
-                }
-
-                @Override
-                public void onFailure(Exception e) {
-                    listener.onFailure(e);
-                }
-            });
+        SearchResponse searchResponse = client.prepareSearch(indexName).setQuery(queryBuilder.getCardinalityQuery()).get();
+        if (searchResponse.getHits().getTotalHits() != null && searchResponse.getHits().getTotalHits().value() >= MAX_ALLOWED_RULE_COUNT) {
+            listener.onFailure(
+                new OpenSearchRejectedExecutionException(
+                    "This create operation will violate"
+                        + " the cardinality limit of "
+                        + MAX_ALLOWED_RULE_COUNT
+                        + ". Please delete some stale or redundant rules first"
+                )
+            );
+        }
     }
 
     /**

modules/autotagging-commons/common/src/test/java/org/opensearch/rule/service/IndexStoredRulePersistenceServiceTests.java

@@ -25,6 +25,7 @@
 import org.opensearch.common.util.concurrent.ThreadContext;
 import org.opensearch.core.action.ActionListener;
 import org.opensearch.core.common.bytes.BytesArray;
+import org.opensearch.core.concurrency.OpenSearchRejectedExecutionException;
 import org.opensearch.core.index.shard.ShardId;
 import org.opensearch.index.engine.DocumentMissingException;
 import org.opensearch.index.query.QueryBuilder;
@@ -109,6 +110,7 @@ public void setUp() throws Exception {
         queryBuilder = mock(QueryBuilder.class);
         when(queryBuilder.filter(any())).thenReturn(queryBuilder);
         when(ruleQueryMapper.from(any(GetRuleRequest.class))).thenReturn(queryBuilder);
+        when(ruleQueryMapper.getCardinalityQuery()).thenReturn(mock(QueryBuilder.class));
         when(ruleEntityParser.parse(anyString())).thenReturn(rule);
 
         rulePersistenceService = new IndexStoredRulePersistenceService(
@@ -144,6 +146,25 @@ public void testCreateRuleOnExistingIndex() throws Exception {
         assertNotNull(responseCaptor.getValue().getRule());
     }
 
+    public void testCardinalityCheckBasedFailure() throws Exception {
+        CreateRuleRequest createRuleRequest = mock(CreateRuleRequest.class);
+        when(createRuleRequest.getRule()).thenReturn(rule);
+        when(rule.toXContent(any(), any())).thenAnswer(invocation -> invocation.getArgument(0));
+
+        SearchResponse searchResponse = mock(SearchResponse.class);
+        when(searchResponse.getHits()).thenReturn(
+            new SearchHits(new SearchHit[] {}, new TotalHits(10000, TotalHits.Relation.EQUAL_TO), 1.0f)
+        );
+        when(searchRequestBuilder.get()).thenReturn(searchResponse);
+
+        ActionListener<CreateRuleResponse> listener = mock(ActionListener.class);
+        rulePersistenceService.createRule(createRuleRequest, listener);
+
+        ArgumentCaptor<Exception> exceptionCaptor = ArgumentCaptor.forClass(OpenSearchRejectedExecutionException.class);
+        verify(listener).onFailure(exceptionCaptor.capture());
+        assertNotNull(exceptionCaptor.getValue());
+    }
+
     public void testConcurrentCreateDuplicateRules() throws InterruptedException {
         ExecutorService singleThreadExecutor = Executors.newSingleThreadExecutor();
         int threadCount = 10;