Record events for cluster operator status

Author: enxebre

pkg/operator/status.go

@@ -5,6 +5,8 @@ import (
 	"reflect"
 	"strings"
 
+	v1 "k8s.io/api/core/v1"
+
 	"github.com/golang/glog"
 
 	osconfigv1 "github.com/openshift/api/config/v1"
@@ -39,10 +41,18 @@ func (optr *Operator) statusProgressing() error {
 		return err
 	}
 	var isProgressing osconfigv1.ConditionStatus
+
+	co, err := optr.getOrCreateClusterOperator()
+	if err != nil {
+		glog.Errorf("Failed to get or create Cluster Operator: %v", err)
+		return err
+	}
+
 	var message string
 	if !reflect.DeepEqual(desiredVersions, currentVersions) {
 		glog.V(2).Info("Syncing status: progressing")
 		message = fmt.Sprintf("Progressing towards %s", optr.printOperandVersions())
+		optr.eventRecorder.Eventf(co, v1.EventTypeNormal, "Status upgrade", message)
 		isProgressing = osconfigv1.ConditionTrue
 	} else {
 		glog.V(2).Info("Syncing status: re-syncing")
@@ -67,11 +77,6 @@ func (optr *Operator) statusProgressing() error {
 		},
 	}
 
-	co, err := optr.getOrCreateClusterOperator()
-	if err != nil {
-		glog.Errorf("Failed to get or create Cluster Operator: %v", err)
-		return err
-	}
 	return optr.syncStatus(co, conds)
 }
 
@@ -145,6 +150,7 @@ func (optr *Operator) statusFailing(error string) error {
 	if err != nil {
 		return err
 	}
+	optr.eventRecorder.Eventf(co, v1.EventTypeWarning, "Status failing", error)
 	glog.V(2).Info("Syncing status: failing")
 	return optr.syncStatus(co, conds)
 }

pkg/operator/status_test.go

@@ -1,11 +1,13 @@
 package operator
 
 import (
+	"testing"
+
 	osconfigv1 "github.com/openshift/api/config/v1"
 	fakeconfigclientset "github.com/openshift/client-go/config/clientset/versioned/fake"
 	"github.com/stretchr/testify/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"testing"
+	"k8s.io/client-go/tools/record"
 )
 
 func TestPrintOperandVersions(t *testing.T) {
@@ -61,6 +63,7 @@ func TestOperatorStatusProgressing(t *testing.T) {
 				Version: "1.0",
 			},
 		},
+		eventRecorder: record.NewFakeRecorder(5),
 	}
 	for i, tc := range tCases {
 		co := &osconfigv1.ClusterOperator{ObjectMeta: metav1.ObjectMeta{Name: clusterOperatorName}}