Adding new test case for robot framework

Author: Kasturi Narra

test/suites/optional/generic-device-plugin.robot

@@ -8,7 +8,7 @@ Variables           strings.py
 Library             strings.py
 
 Suite Setup         Setup Suite With Namespace
-Suite Teardown      Teardown Suite With Namespace
+Suite Teardown      Teardown Suite With GDP Cleanup
 
 Test Tags           generic-device-plugin
 
@@ -20,35 +20,50 @@ ${NAMESPACE}    ${EMPTY}
 *** Test Cases ***
 Sanity Test
     [Documentation]    Performs a simple test of Generic Device Plugin
-    [Setup]    Run Keywords
-    ...    Enable And Configure GDP
-    ...    Enable Serialsim
-    ...    Copy Script To Host
+    [Setup]    GDP Test Setup    ${GDP_CONFIG_DROPIN}
 
-    Wait Until Device Is Allocatable
-
-    Command Should Work    crictl pull registry.access.redhat.com/ubi9/ubi:9.6
-    Start Script On Host
     Create Test Job
+    Wait For Job Completion And Check Logs
+
+    [Teardown]    GDP Test Teardown
+
+Verify that mountPath correctly renames the device within the container
+    [Documentation]    Performs a test of Generic Device Plugin with custom mountPath configuration
+    [Setup]    GDP Test Setup    ${GDP_CONFIG_DROPIN_WITH_MOUNT}
 
+    Create Test Job With Modified Script
     Wait For Job Completion And Check Logs
 
-    [Teardown]    Run Keywords
-    ...    Stop Script On Host
-    ...    Disable GDP
+    [Teardown]    GDP Test Teardown
 
 
 *** Keywords ***
+GDP Test Setup
+    [Documentation]    Common setup for GDP tests - configures GDP, enables serialsim, prepares environment
+    [Arguments]    ${config_content}
+    Enable And Configure GDP    ${config_content}
+    Enable Serialsim
+    Copy Script To Host
+    Wait Until Device Is Allocatable
+    Command Should Work    crictl pull registry.access.redhat.com/ubi9/ubi:9.6
+    Start Script On Host
+
+GDP Test Teardown
+    [Documentation]    Common teardown for GDP tests - stops script, cleans up resources, disables GDP
+    Stop Script On Host
+    Cleanup Test Resources
+    Disable GDP
+
 Enable And Configure GDP
     [Documentation]    Enables GDP and adds fake device path in MicroShift configuration
-    Drop In MicroShift Config    ${GDP_CONFIG_DROPIN}    10-gdp
+    [Arguments]    ${config_content}=${GDP_CONFIG_DROPIN}    ${dropin_name}=10-gdp
+    Drop In MicroShift Config    ${config_content}    ${dropin_name}
     Restart MicroShift
 
 Disable GDP
-    [Documentation]    Removes GDP configuration drop-in
-    Remove Drop In MicroShift Config    10-gdp
-    Restart MicroShift
-    Restart Greenboot And Wait For Success
+    [Documentation]    Removes GDP configuration drop-in (without restart)
+    [Arguments]    ${dropin_name}=10-gdp
+    Remove Drop In MicroShift Config    ${dropin_name}
 
 Enable Serialsim
     [Documentation]    Enables the serialsim kernel module.
@@ -75,6 +90,13 @@ Stop Script On Host
     Command Execution    systemctl stop gdp-test-comm
     Command Execution    systemctl reset-failed gdp-test-comm
 
+Cleanup Test Resources
+    [Documentation]    Cleans up test resources including configmap and job
+    Run Keyword And Ignore Error
+    ...    Oc Delete    job/gdp-test -n ${NAMESPACE}
+    Run Keyword And Ignore Error
+    ...    Oc Delete    configmap/gdp-script -n ${NAMESPACE}
+
 Create Test Job
     [Documentation]    Creates Job that spawns test Pod running to completion.
     ${script}=    OperatingSystem.Get File    ./assets/generic-device-plugin/fake-serial-communication.py
@@ -84,11 +106,23 @@ Create Test Job
     Oc Create    -f ${path} -n ${NAMESPACE}
     Oc Create    -f ./assets/generic-device-plugin/job.yaml -n ${NAMESPACE}
 
+Create Test Job With Modified Script
+    [Documentation]    Creates Job that spawns test Pod running to completion with modified script.
+    ${script}=    OperatingSystem.Get File    ./assets/generic-device-plugin/fake-serial-communication.py
+    ${modified_script}=    Replace String
+    ...    ${script}
+    ...    DEVICE_POD = "/dev/ttyPipeB0"
+    ...    DEVICE_POD = "/dev/myrenamedserial"
+    ${configmap}=    Append To Preamble    ${modified_script}
+    Log    ${configmap}
+    ${path}=    Create Random Temp File    ${configmap}
+    Oc Create    -f ${path} -n ${NAMESPACE}
+    Oc Create    -f ./assets/generic-device-plugin/job.yaml -n ${NAMESPACE}
+
 Wait Until Device Is Allocatable
     [Documentation]    Waits until device device.microshift.io/fakeserial is allocatable
     ${node}=    Run With Kubeconfig    oc get node -o=name
     ${node_name}=    Remove String    ${node}    node/
-
     Wait Until Keyword Succeeds    60s    5s
     ...    Device Should Be Allocatable    ${node_name}
 
@@ -113,3 +147,14 @@ Wait For Job Completion And Check Logs
     ...    .items[*].metadata.name
     ${logs}=    Oc Logs    ${pod}    ${NAMESPACE}
     Should Contain    ${logs}    Test successful
+
+Teardown Suite With GDP Cleanup
+    [Documentation]    Suite teardown that cleans up GDP configuration and restarts MicroShift
+    # Clean up any remaining GDP configuration
+    Run Keyword And Ignore Error
+    ...    Remove Drop In MicroShift Config    10-gdp
+    # Restart MicroShift to clean state for next suite
+    Restart MicroShift
+    Restart Greenboot And Wait For Success
+    # Call original suite teardown
+    Teardown Suite With Namespace

test/suites/optional/strings.py

@@ -8,6 +8,17 @@
              - path: /dev/ttyPipeB0
 '''
 
+GDP_CONFIG_DROPIN_WITH_MOUNT = '''
+genericDevicePlugin:
+  status: Enabled
+  devices:
+     - name: fakeserial
+       groups:
+         - paths:
+             - path: /dev/ttyPipeB0
+               mountPath: /dev/myrenamedserial
+'''
+
 CONFIGMAP_PREAMBLE = '''
 apiVersion: v1
 kind: ConfigMap