chore: pr comments

Author: jakobmoellerdev

pkg/components/storage.go

@@ -62,7 +62,7 @@ func startCSIPlugin(ctx context.Context, cfg *config.Config, kubeconfigPath stri
 // deleteLegacyResources deletes the legacy resources of TopoLVM.
 // TODO: Remove this function in the next release.
 func deleteLegacyResources(ctx context.Context, kubeconfigPath string) error {
-	klog.Infof("Deleting legacy resources of TopoLVM (this is a migration operation and will disappear in the future release)")
+	klog.Infof("Deleting legacy resources of TopoLVM (this is a migration operation and will disappear in the next release)")
 	return assets.DeleteGeneric(ctx, []runtime.Object{
 		&appsv1.Deployment{ObjectMeta: metav1.ObjectMeta{Name: "topolvm-controller", Namespace: "openshift-storage"}},
 		&appsv1.DaemonSet{ObjectMeta: metav1.ObjectMeta{Name: "topolvm-node", Namespace: "openshift-storage"}},
@@ -218,7 +218,6 @@ func loadCSIPluginConfig(ctx context.Context,
 		watcher, err := fsnotify.NewWatcher()
 		if err != nil {
 			klog.Errorf("unable to set up file watcher: %v", err)
-			cancel(err)
 			return
 		}
 		defer func() {
@@ -228,7 +227,6 @@ func loadCSIPluginConfig(ctx context.Context,
 		}()
 		if err = watcher.Add(usrCfgDir); err != nil {
 			klog.Errorf("unable to add file path to watcher: %v", err)
-			cancel(err)
 			return
 		}
 

scripts/auto-rebase/rebase-lvms.sh

@@ -184,7 +184,7 @@ patch_namespace() {
     if [[ $(yq e ".metadata.namespace == \"${namespace}\"" "${file}") == "false" ]]; then
       echo "patching .metadata.namespace to \"${namespace}\" in ${file}"
       # Set the .metadata.namespace to the specified value
-      yq e '.metadata.namespace = "'"${namespace}"'"' -i "${file}"
+      yq e ".metadata.namespace == \"${namespace}\"" -i "${file}"
     fi
   fi
 }

scripts/auto-rebase/rebase_job_entrypoint.sh

@@ -71,7 +71,6 @@ pullspec_release_lvms="registry.redhat.io/lvms4/lvms-operator-bundle:${release_l
 # the latest lvms release candidate replicated from CPaaS into quay
 pullspec_release_lvms_fallback="quay.io/lvms_dev/lvms4-lvms-operator-bundle:${release_lvms}"
 
-# You can also pass the version as a command-line argument
 lvms_is_candidate_build=$(check_semver_suffix "${release_lvms}")
 if [ "$lvms_is_candidate_build" == "false" ]; then
     ./scripts/auto-rebase/rebase-lvms.sh to "${pullspec_release_lvms}"