Merge pull request #4328 from ggiguash/fix_bootc_embedded_image_pull

NO-ISSUE: Fail the bootc image build if all retries for container pull fail

Author: openshift-merge-bot[bot]

test/image-blueprints-bootc/layer2-source/group2/rhel95-bootc-source-isolated.containerfile

@@ -34,8 +34,11 @@ RUN --mount=type=secret,id=pullsecret,dst=/run/secrets/pull-secret.json \
             --authfile /run/secrets/pull-secret.json \
             --root /var/lib/containers/storage-preloaded \
             "docker://{{ . }}" && break; \
-        echo "Attempt $i failed. Retrying in 5 seconds..."; \
-        sleep 5; \
+        if [ $i -eq 3 ] ; then \
+            echo "ERROR: Failed to pull {{ . }} image after 3 attempts"; \
+            exit 1; \
+        fi; \
+        echo "Attempt $i failed. Retrying in 5 seconds..." && sleep 5; \
     done
 # {{ end }}
 

test/image-blueprints-bootc/layer2-source/group3/cos9-bootc-source-isolated.containerfile

@@ -14,8 +14,11 @@ RUN --mount=type=secret,id=pullsecret,dst=/run/secrets/pull-secret.json \
             --authfile /run/secrets/pull-secret.json \
             --root /var/lib/containers/storage-preloaded \
             "docker://{{ . }}" && break; \
-        echo "Attempt $i failed. Retrying in 5 seconds..."; \
-        sleep 5; \
+        if [ $i -eq 3 ] ; then \
+            echo "ERROR: Failed to pull {{ . }} image after 3 attempts"; \
+            exit 1; \
+        fi; \
+        echo "Attempt $i failed. Retrying in 5 seconds..." && sleep 5; \
     done
 # {{ end }}