Skip to content

Commit bf7c1f1

Browse files
pmtkggiguash
andauthored
Apply suggestions from code review
Co-authored-by: Gregory Giguashvili <[email protected]>
1 parent 300c84e commit bf7c1f1

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

docs/contributor/greenboot.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,21 +53,20 @@ core services.
5353
The script starts by running sanity checks to verify that it is executed from
5454
the `root` account.
5555

56-
Then, executes `microshift healthcheck` command with following options:
56+
Then, it executes `microshift healthcheck` command with following options:
5757
- `-v=2` to increase verbosity of the output
5858
- `--timeout="${WAIT_TIMEOUT_SECS}s"` to override default 300s timeout value
5959
- `--namespace busybox` to specify the Namespace of the workloads
6060
- `--deployments busybox-deployment` to specify Deployment to check the readiness of
6161

62-
Internally, `microshift healthcheck` with above set of parameters, for a
63-
specified time, checks if workload of provided type exists, then verifies its
64-
status so the amount of ready replicas (Pods) matches the expected amount.
62+
Internally, `microshift healthcheck` checks if workload of the provided type exists and verifies its
63+
status for the specified timeout duration, so the amount of ready replicas (Pods) matches the expected amount.
6564

6665
`microshift healthcheck` also accepts other parameters to specify other kinds
6766
of workload: `--daemonsets` and `--statefulsets`. These options take
6867
comma-delimited list of resources, e.g.: `--daemonsets ovnkube-master,ovnkube-node`.
6968

70-
Alternatively, an `--custom` option can be used with a JSON string, for example:
69+
Alternatively, a `--custom` option can be used with a JSON string, for example:
7170
```
7271
microshift healthcheck --custom '{"openshift-storage":{"deployments": ["lvms-operator"], "daemonsets": ["vg-manager"]}, "openshift-ovn-kubernetes":{"daemonsets": ["ovnkube-master", "ovnkube-node"]}}'
7372
```

0 commit comments

Comments
 (0)