Skip to content

Commit e480534

Browse files
committed
Add comment about script being used by older branches of MicroShift
1 parent c2d8b52 commit e480534

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

scripts/ci-nvidia-device-plugin/setup/03-nvidia-container-toolkit.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ sudo nvidia-ctk runtime configure --runtime=crio --set-as-default --config=/etc/
1919
# Update runtimes from ["docker-runc", "runc", "crun"] to ["crun", "docker-runc", "runc"]
2020
sudo sed -i 's/^runtimes =.*$/runtimes = ["crun", "docker-runc", "runc"]/g' /etc/nvidia-container-runtime/config.toml
2121

22+
# ci-nvidia-device-plugin scripts are used by many branches, not only the main branch.
23+
# Therefore the scripts include workarounds for older MicroShift versions.
2224
# MicroShift 4.14 and 4.15 don't use numerical prefixes.
2325
# Rename the files, so the 99-nvidia.conf overwrites them.
2426
if [ -f /etc/crio/crio.conf.d/microshift.conf ]; then

scripts/ci-nvidia-device-plugin/tests/04-verify-device-plugin.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
set -xeuo pipefail
44

5+
# ci-nvidia-device-plugin scripts are used by many branches, not only the main branch.
6+
# Therefore the scripts include workarounds for older MicroShift versions.
7+
# For the versions that do not have the healthcheck command, the script uses oc rollout status.
8+
59
if microshift --help | grep -q "healthcheck"; then
610
sudo microshift healthcheck \
711
--namespace nvidia-device-plugin \

0 commit comments

Comments
 (0)