Refactor CloudStorage controller tests to use mock bucket client

- Add mock bucket client implementation for testing
- Refactor all tests to use dependency injection via BucketClientFactory
- Extract mock AWS credentials to a constant
- Create helper function for test cloud credentials secret creation
- Add helper function to find conditions by type
- Improve test reliability by using mocks instead of actual bucket operations
- Add retry logic and status conditions to CloudStorage controller

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: kaovilai

internal/controller/cloudstorage_controller.go

@@ -54,6 +54,9 @@ type CloudStorageReconciler struct {
 	Scheme        *runtime.Scheme
 	Log           logr.Logger
 	EventRecorder record.EventRecorder
+	// BucketClientFactory is an optional factory function for creating bucket clients
+	// Used for dependency injection in tests. If nil, uses default bucketpkg.NewClient
+	BucketClientFactory func(bucket oadpv1alpha1.CloudStorage, c client.Client) (bucketpkg.Client, error)
 }
 
 //+kubebuilder:rbac:groups=oadp.openshift.io,resources=cloudstorages,verbs=get;list;watch;create;update;patch;delete
@@ -86,7 +89,14 @@ func (b CloudStorageReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 		return ctrl.Result{Requeue: true}, nil
 	}
 
-	clnt, err := bucketpkg.NewClient(bucket, b.Client)
+	// Use injected factory if available (for testing), otherwise use default
+	var clnt bucketpkg.Client
+	var err error
+	if b.BucketClientFactory != nil {
+		clnt, err = b.BucketClientFactory(bucket, b.Client)
+	} else {
+		clnt, err = bucketpkg.NewClient(bucket, b.Client)
+	}
 	if err != nil {
 		return result, err
 	}