Fixing typo and removing extra logic wrt secret name

Author: savitharaghunathan

controllers/velero.go

@@ -534,7 +534,7 @@ func (r *VeleroReconciler) getVeleroResourceReqs(velero *oadpv1alpha1.Velero) co
 // For later: Move this code into validator.go when more need for validation arises
 // TODO: if multiple default plugins exist, ensure we validate all of them.
 // Right now its sequential validation
-func (r *VeleroReconciler) ValidateVeleroPiugins(log logr.Logger) (bool, error) {
+func (r *VeleroReconciler) ValidateVeleroPlugins(log logr.Logger) (bool, error) {
 	velero := oadpv1alpha1.Velero{}
 	if err := r.Get(r.Context, r.NamespacedName, &velero); err != nil {
 		return false, err

controllers/velero_controller.go

@@ -82,7 +82,7 @@ func (r *VeleroReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	}
 
 	_, err := ReconcileBatch(r.Log,
-		r.ValidateVeleroPiugins,
+		r.ValidateVeleroPlugins,
 		r.ReconcileVeleroSecurityContextConstraint,
 		r.ReconcileResticRestoreHelperConfig,
 		r.ValidateBackupStorageLocations,

pkg/credentials/credentials.go

@@ -155,14 +155,6 @@ func AppendCloudProviderVolumes(velero *oadpv1alpha1.Velero, ds *appsv1.DaemonSe
 			// default secret name
 			secretName := cloudProviderMap.SecretName
 
-			// check if secret name is specified in BSL config and use it instead of the default one; Note: assuming one BSL per provider
-			for _, bsl := range velero.Spec.BackupStorageLocations {
-				if bsl.Provider == string(plugin) && bsl.Credential != nil && len(bsl.Credential.Name) > 0 {
-					secretName = bsl.Credential.Name
-					continue
-				}
-			}
-
 			ds.Spec.Template.Spec.Volumes = append(
 				ds.Spec.Template.Spec.Volumes,
 				corev1.Volume{
@@ -221,15 +213,6 @@ func AppendPluginSpecificSpecs(velero *oadpv1alpha1.Velero, veleroDeployment *ap
 			}
 			// set default secret name to use
 			secretName := pluginSpecificMap.SecretName
-			// Grab secret name from BSL for this cloud provider plugin
-			for _, bsl := range velero.Spec.BackupStorageLocations {
-				if bsl.Provider == string(plugin) {
-					if bsl.Credential != nil && len(bsl.Credential.Name) > 0 {
-						secretName = bsl.Credential.Name
-					}
-					continue
-				}
-			}
 			// append plugin specific volume mounts
 			if veleroContainer != nil {
 				veleroContainer.VolumeMounts = append(