Add tech preview features struct to DPA CRD, add enableDataMover flag to DPA features , data-mover controller deployment and data-mover csi plugin (#727)

* add datamover controller deployment

* revert to org images in csv

* add enableDataMover boolean flag on DPA CR

* update csi plugin image based on dm flag and add unsupported overrides for dm controller

* add labels to DM deployment and unit tests

* make users specifically specify enabledataMover as true for DM functionality

* revert default dpa sample file

* update DPA API and run make bundle

* address feedback and add events perms

* add CRDs - VolumeSnapshotBackup and VolumeSnapshotRestore

Author: shubham-pampattiwar

api/v1alpha1/oadp_types.go

@@ -30,6 +30,7 @@ const ReconcileCompleteMessage = "Reconcile complete"
 
 const OadpOperatorLabel = "openshift.io/oadp"
 const RegistryDeploymentLabel = "openshift.io/oadp-registry"
+const DataMoverDeploymentLabel = "openshift.io/oadp-data-mover"
 
 type DefaultPlugin string
 
@@ -53,6 +54,7 @@ const OpenShiftPluginImageKey UnsupportedImageKey = "openshiftPluginImageFqin"
 const AzurePluginImageKey UnsupportedImageKey = "azurePluginImageFqin"
 const GCPPluginImageKey UnsupportedImageKey = "gcpPluginImageFqin"
 const CSIPluginImageKey UnsupportedImageKey = "csiPluginImageFqin"
+const DataMoverImageKey UnsupportedImageKey = "dataMoverImageFqin"
 const ResticRestoreImageKey UnsupportedImageKey = "resticRestoreImageFqin"
 const RegistryImageKey UnsupportedImageKey = "registryImageFqin"
 const KubeVirtPluginImageKey UnsupportedImageKey = "kubevirtPluginImageFqin"
@@ -158,6 +160,13 @@ type SnapshotLocation struct {
 	Velero *velero.VolumeSnapshotLocationSpec `json:"velero"`
 }
 
+// Features defines the configuration for the DPA to enable the tech preview features
+type Features struct {
+	// EnableDataMover is used to specify whether you want to deploy the volume snapshot mover controller and a modified csi datamover plugin
+	// +optional
+	EnableDataMover bool `json:"enableDataMover,omitempty"`
+}
+
 // DataProtectionApplicationSpec defines the desired state of Velero
 type DataProtectionApplicationSpec struct {
 	// BackupLocations defines the list of desired configuration to use for BackupStorageLocations
@@ -184,9 +193,11 @@ type DataProtectionApplicationSpec struct {
 	// BackupImages is used to specify whether you want to deploy a registry for enabling backup and restore of images
 	// +optional
 	BackupImages *bool `json:"backupImages,omitempty"`
-
 	// Configuration is used to configure the data protection application's server config
 	Configuration *ApplicationConfig `json:"configuration"`
+	// Features defines the configuration for the DPA to enable the OADP tech preview features
+	// +optional
+	Features *Features `json:"features"`
 }
 
 // DataProtectionApplicationStatus defines the observed state of DataProtectionApplication

api/v1alpha1/zz_generated.deepcopy.go

@@ -0,0 +1,205 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  annotations:
+    controller-gen.kubebuilder.io/version: v0.8.0
+  creationTimestamp: null
+  name: volumesnapshotbackups.datamover.oadp.openshift.io
+spec:
+  group: datamover.oadp.openshift.io
+  names:
+    kind: VolumeSnapshotBackup
+    listKind: VolumeSnapshotBackupList
+    plural: volumesnapshotbackups
+    shortNames:
+    - vsb
+    singular: volumesnapshotbackup
+  scope: Namespaced
+  versions:
+  - name: v1alpha1
+    schema:
+      openAPIV3Schema:
+        description: VolumeSnapshotBackup is the Schema for the volumesnapshotbackups
+          API
+        properties:
+          apiVersion:
+            description: 'APIVersion defines the versioned schema of this representation
+              of an object. Servers should convert recognized schemas to the latest
+              internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+            type: string
+          kind:
+            description: 'Kind is a string value representing the REST resource this
+              object represents. Servers may infer this from the endpoint the client
+              submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+            type: string
+          metadata:
+            type: object
+          spec:
+            description: VolumeSnapshotBackupSpec defines the desired state of VolumeSnapshotBackup
+            properties:
+              protectedNamespace:
+                description: Namespace where the Velero deployment is present
+                type: string
+              volumeSnapshotContent:
+                description: 'ObjectReference contains enough information to let you
+                  inspect or modify the referred object. --- New uses of this type
+                  are discouraged because of difficulty describing its usage when
+                  embedded in APIs. 1. Ignored fields.  It includes many fields which
+                  are not generally honored.  For instance, ResourceVersion and FieldPath
+                  are both very rarely valid in actual usage. 2. Invalid usage help.  It
+                  is impossible to add specific help for individual usage.  In most
+                  embedded usages, there are particular restrictions like, "must refer
+                  only to types A and B" or "UID not honored" or "name must be restricted".
+                  Those cannot be well described when embedded. 3. Inconsistent validation.  Because
+                  the usages are different, the validation rules are different by
+                  usage, which makes it hard for users to predict what will happen.
+                  4. The fields are both imprecise and overly precise.  Kind is not
+                  a precise mapping to a URL. This can produce ambiguity during interpretation
+                  and require a REST mapping.  In most cases, the dependency is on
+                  the group,resource tuple and the version of the actual struct is
+                  irrelevant. 5. We cannot easily change it.  Because this type is
+                  embedded in many locations, updates to this type will affect numerous
+                  schemas.  Don''t make new APIs embed an underspecified API type
+                  they do not control. Instead of using this type, create a locally
+                  provided and used type that is well-focused on your reference. For
+                  example, ServiceReferences for admission registration: https://github.com/kubernetes/api/blob/release-1.17/admissionregistration/v1/types.go#L533
+                  .'
+                properties:
+                  apiVersion:
+                    description: API version of the referent.
+                    type: string
+                  fieldPath:
+                    description: 'If referring to a piece of an object instead of
+                      an entire object, this string should contain a valid JSON/Go
+                      field access statement, such as desiredState.manifest.containers[2].
+                      For example, if the object reference is to a container within
+                      a pod, this would take on a value like: "spec.containers{name}"
+                      (where "name" refers to the name of the container that triggered
+                      the event) or if no container name is specified "spec.containers[2]"
+                      (container with index 2 in this pod). This syntax is chosen
+                      only to have some well-defined way of referencing a part of
+                      an object. TODO: this design is not final and this field is
+                      subject to change in the future.'
+                    type: string
+                  kind:
+                    description: 'Kind of the referent. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+                    type: string
+                  name:
+                    description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names'
+                    type: string
+                  namespace:
+                    description: 'Namespace of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/namespaces/'
+                    type: string
+                  resourceVersion:
+                    description: 'Specific resourceVersion to which this reference
+                      is made, if any. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#concurrency-control-and-consistency'
+                    type: string
+                  uid:
+                    description: 'UID of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#uids'
+                    type: string
+                type: object
+            type: object
+          status:
+            description: VolumeSnapshotBackupStatus defines the observed state of
+              VolumeSnapshotBackup
+            properties:
+              completed:
+                type: boolean
+              conditions:
+                description: Include references to the volsync CRs and their state
+                  as they are running
+                items:
+                  description: "Condition contains details for one aspect of the current
+                    state of this API Resource. --- This struct is intended for direct
+                    use as an array at the field path .status.conditions.  For example,
+                    type FooStatus struct{ // Represents the observations of a foo's
+                    current state. // Known .status.conditions.type are: \"Available\",
+                    \"Progressing\", and \"Degraded\" // +patchMergeKey=type // +patchStrategy=merge
+                    // +listType=map // +listMapKey=type Conditions []metav1.Condition
+                    `json:\"conditions,omitempty\" patchStrategy:\"merge\" patchMergeKey:\"type\"
+                    protobuf:\"bytes,1,rep,name=conditions\"` \n // other fields }"
+                  properties:
+                    lastTransitionTime:
+                      description: lastTransitionTime is the last time the condition
+                        transitioned from one status to another. This should be when
+                        the underlying condition changed.  If that is not known, then
+                        using the time when the API field changed is acceptable.
+                      format: date-time
+                      type: string
+                    message:
+                      description: message is a human readable message indicating
+                        details about the transition. This may be an empty string.
+                      maxLength: 32768
+                      type: string
+                    observedGeneration:
+                      description: observedGeneration represents the .metadata.generation
+                        that the condition was set based upon. For instance, if .metadata.generation
+                        is currently 12, but the .status.conditions[x].observedGeneration
+                        is 9, the condition is out of date with respect to the current
+                        state of the instance.
+                      format: int64
+                      minimum: 0
+                      type: integer
+                    reason:
+                      description: reason contains a programmatic identifier indicating
+                        the reason for the condition's last transition. Producers
+                        of specific condition types may define expected values and
+                        meanings for this field, and whether the values are considered
+                        a guaranteed API. The value should be a CamelCase string.
+                        This field may not be empty.
+                      maxLength: 1024
+                      minLength: 1
+                      pattern: ^[A-Za-z]([A-Za-z0-9_,:]*[A-Za-z0-9_])?$
+                      type: string
+                    status:
+                      description: status of the condition, one of True, False, Unknown.
+                      enum:
+                      - "True"
+                      - "False"
+                      - Unknown
+                      type: string
+                    type:
+                      description: type of condition in CamelCase or in foo.example.com/CamelCase.
+                        --- Many .condition.type values are consistent across resources
+                        like Available, but because arbitrary conditions can be useful
+                        (see .node.status.conditions), the ability to deconflict is
+                        important. The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
+                      maxLength: 316
+                      pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
+                      type: string
+                  required:
+                  - lastTransitionTime
+                  - message
+                  - reason
+                  - status
+                  - type
+                  type: object
+                type: array
+              phase:
+                description: volumesnapshot backup phase status
+                type: string
+              resticrepository:
+                description: Includes restic repository path
+                type: string
+              sourcePVCData:
+                description: Includes source PVC name and size
+                properties:
+                  name:
+                    description: name of the PersistentVolumeClaim
+                    type: string
+                  size:
+                    description: size of the PersistentVolumeClaim
+                    type: string
+                type: object
+            type: object
+        type: object
+    served: true
+    storage: true
+    subresources:
+      status: {}
+status:
+  acceptedNames:
+    kind: ""
+    plural: ""
+  conditions: []
+  storedVersions: []