CSI Backrestore E2E test

hhpatel14 · hhpatel14 · commit 8b02ce1a2457 · 2021-11-01T23:35:05.000-04:00
diff --git a/tests/e2e/backup_restore_suite_test.go b/tests/e2e/backup_restore_suite_test.go
@@ -23,25 +23,6 @@ var _ = Describe("AWS backup restore tests", func() {
 
 		err = createCredentialsSecret(credData, namespace, credSecretRef)
 		Expect(err).NotTo(HaveOccurred())
-
-		err = vel.Build()
-		Expect(err).NotTo(HaveOccurred())
-
-		err = vel.CreateOrUpdate(&vel.CustomResource.Spec)
-		Expect(err).NotTo(HaveOccurred())
-
-		log.Printf("Waiting for velero pod to be running")
-		Eventually(isVeleroPodRunning(namespace), timeoutMultiplier*time.Minute*3, time.Second*5).Should(BeTrue())
-
-		if vel.CustomResource.Spec.EnableRestic == nil || *vel.CustomResource.Spec.EnableRestic {
-			log.Printf("Waiting for restic pods to be running")
-			Eventually(areResticPodsRunning(namespace), timeoutMultiplier*time.Minute*3, time.Second*5).Should(BeTrue())
-		}
-		
-		if vel.CustomResource.Spec.BackupImages == nil || *vel.CustomResource.Spec.BackupImages {
-			log.Printf("Waiting for registry pods to be running")
-			Eventually(areRegistryDeploymentsAvailable(namespace), timeoutMultiplier*time.Minute*3, time.Second*5).Should(BeTrue())
-		}
 	})
 
 	var _ = AfterEach(func() {
@@ -56,6 +37,7 @@ var _ = Describe("AWS backup restore tests", func() {
 		ApplicationTemplate  string
 		ApplicationNamespace string
 		Name                 string
+		BackupRestoreType    string
 		PreBackupVerify      VerificationFunction
 		PostRestoreVerify    VerificationFunction
 		MaxK8SVersion        *k8sVersion
@@ -64,6 +46,32 @@ var _ = Describe("AWS backup restore tests", func() {
 
 	DescribeTable("backup and restore applications",
 		func(brCase BackupRestoreCase, expectedErr error) {
+
+			err := vel.Build(brCase.BackupRestoreType)
+			Expect(err).NotTo(HaveOccurred())
+
+			err = vel.CreateOrUpdate(&vel.CustomResource.Spec)
+			Expect(err).NotTo(HaveOccurred())
+
+			log.Printf("Waiting for velero pod to be running")
+			Eventually(isVeleroPodRunning(namespace), timeoutMultiplier*time.Minute*3, time.Second*5).Should(BeTrue())
+
+			if brCase.BackupRestoreType == "restic" {
+				if vel.CustomResource.Spec.EnableRestic == nil || *vel.CustomResource.Spec.EnableRestic {
+					log.Printf("Waiting for restic pods to be running")
+					Eventually(areResticPodsRunning(namespace), timeoutMultiplier*time.Minute*3, time.Second*5).Should(BeTrue())
+				}
+			}
+			if brCase.BackupRestoreType == "csi" {
+				log.Printf("Creating VolumeSnapshot for CSI backuprestore of %s", brCase.Name)
+				err = installApplication(vel.Client, "./sample-applications/mssql-persistent/volumeSnapshotClass.yaml")
+				Expect(err).ToNot(HaveOccurred())
+			}
+
+			if vel.CustomResource.Spec.BackupImages == nil || *vel.CustomResource.Spec.BackupImages {
+				log.Printf("Waiting for registry pods to be running")
+				Eventually(areRegistryDeploymentsAvailable(namespace), timeoutMultiplier*time.Minute*3, time.Second*5).Should(BeTrue())
+			}
 			if notVersionTarget, reason := NotServerVersionTarget(brCase.MinK8SVersion, brCase.MaxK8SVersion); notVersionTarget {
 				Skip(reason)
 			}
@@ -74,7 +82,7 @@ var _ = Describe("AWS backup restore tests", func() {
 
 			// install app
 			log.Printf("Installing application for case %s", brCase.Name)
-			err := installApplication(vel.Client, brCase.ApplicationTemplate)
+			err = installApplication(vel.Client, brCase.ApplicationTemplate)
 			Expect(err).ToNot(HaveOccurred())
 			// wait for pods to be running
 			Eventually(areApplicationPodsRunning(brCase.ApplicationNamespace), timeoutMultiplier*time.Minute*2, time.Second*5).Should(BeTrue())
@@ -131,11 +139,38 @@ var _ = Describe("AWS backup restore tests", func() {
 			log.Printf("Uninstalling application for case %s", brCase.Name)
 			err = uninstallApplication(vel.Client, brCase.ApplicationTemplate)
 			Expect(err).ToNot(HaveOccurred())
+
+			if brCase.BackupRestoreType == "csi" {
+				log.Printf("Deleting VolumeSnapshot for CSI backuprestore of %s", brCase.Name)
+				err = uninstallApplication(vel.Client, "./sample-applications/mssql-persistent/volumeSnapshotClass.yaml")
+				Expect(err).ToNot(HaveOccurred())
+			}
 		},
+		Entry("MSSQL application CSI", BackupRestoreCase{
+			ApplicationTemplate:  "./sample-applications/mssql-persistent/mssql-persistent-csi-template.yaml",
+			ApplicationNamespace: "mssql-persistent",
+			Name:                 "mssql-e2e",
+			BackupRestoreType:    "csi",
+			PreBackupVerify: VerificationFunction(func(ocClient client.Client, namespace string) error {
+				return nil
+			}),
+			PostRestoreVerify: VerificationFunction(func(ocClient client.Client, namespace string) error {
+				// This test confirms that SCC restore logic in our plugin is working
+				exists, err := doesSCCExist(ocClient, "mssql-persistent-scc")
+				if err != nil {
+					return err
+				}
+				if !exists {
+					return errors.New("did not find MSSQL scc after restore")
+				}
+				return nil
+			}),
+		}, nil),
 		Entry("MSSQL application", BackupRestoreCase{
 			ApplicationTemplate:  "./sample-applications/mssql-persistent/mssql-persistent-template.yaml",
 			ApplicationNamespace: "mssql-persistent",
 			Name:                 "mssql-e2e",
+			BackupRestoreType:    "restic",
 			PreBackupVerify: VerificationFunction(func(ocClient client.Client, namespace string) error {
 				return nil
 			}),
@@ -155,6 +190,7 @@ var _ = Describe("AWS backup restore tests", func() {
 			ApplicationTemplate:  "./sample-applications/parks-app/manifest.yaml",
 			ApplicationNamespace: "parks-app",
 			Name:                 "parks-e2e",
+			BackupRestoreType:    "restic",
 			PreBackupVerify: VerificationFunction(func(ocClient client.Client, namespace string) error {
 				Eventually(isDCReady(ocClient, "parks-app", "restify"), timeoutMultiplier*time.Minute*5, time.Second*10).Should(BeTrue())
 				return nil
@@ -168,6 +204,7 @@ var _ = Describe("AWS backup restore tests", func() {
 			ApplicationTemplate:  "./sample-applications/parks-app/manifest4.8.yaml",
 			ApplicationNamespace: "parks-app",
 			Name:                 "parks-e2e",
+			BackupRestoreType:    "restic",
 			PreBackupVerify: VerificationFunction(func(ocClient client.Client, namespace string) error {
 				Eventually(isDCReady(ocClient, "parks-app", "restify"), timeoutMultiplier*time.Minute*5, time.Second*10).Should(BeTrue())
 				return nil
diff --git a/tests/e2e/sample-applications/mssql-persistent/mssql-persistent-csi-template.yaml b/tests/e2e/sample-applications/mssql-persistent/mssql-persistent-csi-template.yaml
@@ -0,0 +1,177 @@
+apiVersion: v1
+kind: List
+items:
+  - kind: Namespace
+    apiVersion: v1
+    metadata:
+      name: mssql-persistent
+      labels:
+        app: mssql
+  - apiVersion: v1
+    kind: Secret
+    metadata:
+      name: mssql-secret
+      namespace: mssql-persistent
+      labels:
+        app: mssql
+    stringData:
+      mssql-password: P@ssw0rd1!
+  - apiVersion: v1
+    kind: ServiceAccount
+    metadata:
+      name: mssql-persistent-sa
+      namespace: mssql-persistent
+      labels:
+        component: mssql-persistent
+  - apiVersion: v1
+    kind: PersistentVolumeClaim
+    metadata:
+      name: mssql-pvc
+      namespace: mssql-persistent
+      labels:
+        app: mssql
+    spec:
+      accessModes:
+      - ReadWriteOnce
+      resources:
+        requests:
+          storage: 10Gi
+      storageClassName: gp2-csi
+  - kind: SecurityContextConstraints
+    apiVersion: security.openshift.io/v1
+    metadata:
+      name: mssql-persistent-scc
+    allowPrivilegeEscalation: true
+    allowPrivilegedContainer: true
+    runAsUser:
+      type: RunAsAny
+    seLinuxContext:
+      type: RunAsAny
+    fsGroup:
+      type: RunAsAny
+    supplementalGroups:
+      type: RunAsAny
+    volumes:
+    - '*'
+    users:
+    - system:admin
+    - system:serviceaccount:mssql-persistent:mssql-persistent-sa
+  - apiVersion: apps.openshift.io/v1
+    kind: DeploymentConfig
+    metadata:
+      name: mssql-deployment
+      namespace: mssql-persistent
+      labels:
+        e2e-app: "true"
+        app: mssql
+    spec:
+      replicas: 1
+      selector:
+        name: mssql
+      strategy:
+        type: Recreate
+      template:
+        metadata:
+          labels:
+            e2e-app: "true"
+            name: mssql
+            app: mssql
+        spec:
+          serviceAccountName: mssql-persistent-sa
+          containers:
+          - env:
+            - name: ACCEPT_EULA
+              value: "Y"
+            - name: SA_PASSWORD
+              valueFrom:
+                secretKeyRef:
+                  key: mssql-password
+                  name: mssql-secret
+            image: quay.io/ocpmigrate/mssql-server:latest
+            imagePullPolicy: Always
+            name: mssql
+            securityContext:
+              privileged: true
+            ports:
+            - containerPort: 1433
+            resources:
+              limits:
+                memory: "3Gi"
+                cpu: "0.5"
+              requests:
+                memory: "3Gi"
+                cpu: "0.5"
+            volumeMounts:
+            - mountPath: "/var/opt/mssql/data"
+              name: mssql-vol
+          volumes:
+          - name: mssql-vol
+            persistentVolumeClaim:
+              claimName: mssql-pvc
+  - apiVersion: v1
+    kind: Service
+    metadata:
+      name: mssql-service
+      namespace: mssql-persistent
+    spec:
+      selector:
+        app: mssql
+      ports:
+        - protocol: TCP
+          port: 1433
+          targetPort: 1433
+      type: ClusterIP
+  - apiVersion: apps/v1
+    kind: Deployment
+    metadata:
+      name: mssql-app-deployment
+      namespace: mssql-persistent
+      labels:
+        e2e-app: "true"
+    spec:
+      replicas: 1
+      selector:
+        matchLabels:
+          app: mssql-app
+      template:
+        metadata:
+          labels:
+            e2e-app: "true"
+            app: mssql-app
+        spec:
+          terminationGracePeriodSeconds: 10
+          serviceAccountName: mssql-persistent-sa
+          containers:
+          - name: mssql-app
+            image: quay.io/ocpmigrate/mssql-sample-app:microsoft
+            imagePullPolicy: Always
+            ports:
+            - containerPort: 5000
+            securityContext:
+              privileged: true
+            env:
+            - name: ConnString
+              value: "Server=mssql-service.mssql-persistent.svc.cluster.local;Database=ProductCatalog;User ID=WebLogin; password=SQLPass1234!"
+  - apiVersion: v1
+    kind: Service
+    metadata:
+      name: mssql-app-service
+      namespace: mssql-persistent
+    spec:
+      selector:
+        app: mssql-app
+      ports:
+        - name: "tcp"
+          protocol: TCP
+          port: 5000
+          targetPort: 5000
+  - apiVersion: route.openshift.io/v1
+    kind: Route
+    metadata:
+      name: mssql-app-route
+      namespace: mssql-persistent
+    spec:
+      path: "/"
+      to:
+        kind: Service
+        name: mssql-app-service
diff --git a/tests/e2e/sample-applications/mssql-persistent/volumeSnapshotClass.yaml b/tests/e2e/sample-applications/mssql-persistent/volumeSnapshotClass.yaml
@@ -0,0 +1,14 @@
+apiVersion: v1
+kind: List
+items:
+  - apiVersion: snapshot.storage.k8s.io/v1
+    kind: VolumeSnapshotClass
+    metadata:
+      name: example-snapclass
+      labels:
+        velero.io/csi-volumesnapshot-class: 'true'
+      annotations:
+        snapshot.storage.kubernetes.io/is-default-class: 'true'
+    driver: ebs.csi.aws.com
+    deletionPolicy: Retain
+   
diff --git a/tests/e2e/velero_helpers.go b/tests/e2e/velero_helpers.go
