OADP-599: Auto create s3 restic secrets for volsync from BSLs (#747)

* adding restic secret creation per bsl

* Adding per bsl restic secret creation

* fixing minor bugs

* Adding owner ref

* add crd bases changes

* adding review feedback

* feedback changes

* adding review feedback

* adding manifest changes

* fixing typpo

* adding checks

* adding func to accomodate different s3 url style

* Adding make bundle changes

* Adding make bundle crd changes

* Changing restic secret name to dm-credential

* adding api changes

* Move DM restic secret creation to reconcile batch and add other review feedback

* adding DM feature conditional

* Adding datamoverenable check func

* fixing make bundle output issue

* Adding bundle changes for vsb CR

* adding more validations to restic secret check

* edit restic secret desc in crd/bases & manifests

Author: savitharaghunathan

api/v1alpha1/oadp_types.go

@@ -31,6 +31,7 @@ const ReconcileCompleteMessage = "Reconcile complete"
 const OadpOperatorLabel = "openshift.io/oadp"
 const RegistryDeploymentLabel = "openshift.io/oadp-registry"
 const DataMoverDeploymentLabel = "openshift.io/oadp-data-mover"
+const OadpBSLnameLabel = "openshift.io/oadp-bsl-name"
 
 type DefaultPlugin string
 
@@ -159,11 +160,21 @@ type SnapshotLocation struct {
 	Velero *velero.VolumeSnapshotLocationSpec `json:"velero"`
 }
 
+// DataMover defines the various config for DPA data mover
+type DataMover struct {
+	// Enable flag is used to specify whether you want to deploy the volume snapshot mover controller
+	// +optional
+	Enable bool `json:"enable,omitempty"`
+	// User supplied Restic Secret name
+	// +optional
+	CredentialName string `json:"credentialName,omitempty"`
+}
+
 // Features defines the configuration for the DPA to enable the tech preview features
 type Features struct {
-	// EnableDataMover is used to specify whether you want to deploy the volume snapshot mover controller and a modified csi datamover plugin
+	// Contains data mover specific configurations
 	// +optional
-	EnableDataMover bool `json:"enableDataMover,omitempty"`
+	DataMover *DataMover `json:"dataMover,omitempty"`
 }
 
 // DataProtectionApplicationSpec defines the desired state of Velero

api/v1alpha1/zz_generated.deepcopy.go

@@ -40,6 +40,13 @@ spec:
               protectedNamespace:
                 description: Namespace where the Velero deployment is present
                 type: string
+              resticSecretRef:
+                description: Restic Secret reference for given BSL
+                properties:
+                  name:
+                    description: Name of the BSL specific restic secret
+                    type: string
+                type: object
               volumeSnapshotContent:
                 description: 'ObjectReference contains enough information to let you
                   inspect or modify the referred object. --- New uses of this type

bundle/manifests/datamover.oadp.openshift.io_volumesnapshotbackups.yaml

@@ -443,11 +443,17 @@ spec:
                 description: Features defines the configuration for the DPA to enable
                   the OADP tech preview features
                 properties:
-                  enableDataMover:
-                    description: EnableDataMover is used to specify whether you want
-                      to deploy the volume snapshot mover controller and a modified
-                      csi datamover plugin
-                    type: boolean
+                  dataMover:
+                    description: Contains data mover specific configurations
+                    properties:
+                      credentialName:
+                        description: User supplied Restic Secret name
+                        type: string
+                      enable:
+                        description: Enable flag is used to specify whether you want
+                          to deploy the volume snapshot mover controller
+                        type: boolean
+                    type: object
                 type: object
               podAnnotations:
                 additionalProperties:

bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml

@@ -40,6 +40,13 @@ spec:
               protectedNamespace:
                 description: Namespace where the Velero deployment is present
                 type: string
+              resticSecretRef:
+                description: Restic Secret reference for given BSL
+                properties:
+                  name:
+                    description: Name of the BSL specific restic secret
+                    type: string
+                type: object
               volumeSnapshotContent:
                 description: 'ObjectReference contains enough information to let you
                   inspect or modify the referred object. --- New uses of this type

config/crd/bases/datamover.oadp.openshift.io_volumesnapshotbackups.yaml

@@ -445,11 +445,17 @@ spec:
                 description: Features defines the configuration for the DPA to enable
                   the OADP tech preview features
                 properties:
-                  enableDataMover:
-                    description: EnableDataMover is used to specify whether you want
-                      to deploy the volume snapshot mover controller and a modified
-                      csi datamover plugin
-                    type: boolean
+                  dataMover:
+                    description: Contains data mover specific configurations
+                    properties:
+                      credentialName:
+                        description: User supplied Restic Secret name
+                        type: string
+                      enable:
+                        description: Enable flag is used to specify whether you want
+                          to deploy the volume snapshot mover controller
+                        type: boolean
+                    type: object
                 type: object
               podAnnotations:
                 additionalProperties: