Skip to content

Commit e162972

Browse files
Merge pull request #1451 from benoit-pierre/fix_paper_tape_regression
Fix paper tape regression
2 parents 1e4d8b3 + 263effa commit e162972

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

news.d/feature/1451.ui.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Improve accessibility:
2+
- Disable tab-key navigation in tables, so focusing a table does not lock global tab-key navigation to it.
3+
- Remove some container widgets, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame).
4+
- In form layouts, link each widget to its label (like each option in the configuration dialog).
5+
- Set the accessible name / description of focusable widgets.
6+
- Use lists for the dictionaries widget, suggestions widget, and the paper tape.

plover/gui_qt/paper_tape.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,6 @@ def _paper_format(self, stroke):
6767
def _raw_format(stroke):
6868
return stroke.rtfcre
6969

70-
def headerData(self, section, orientation, role):
71-
if (section != 0 or orientation != Qt.Horizontal or
72-
role != Qt.DisplayRole or self._style != STYLE_PAPER):
73-
return None
74-
return self._all_keys
75-
7670
def data(self, index, role):
7771
if not index.isValid():
7872
return None
@@ -163,7 +157,8 @@ def _save_state(self, settings):
163157

164158
def on_config_changed(self, config):
165159
if 'system_name' in config:
166-
self._model.reset()
160+
all_keys = self._model.reset()
161+
self.header.setText(all_keys)
167162

168163
@property
169164
def _scroll_at_end(self):

0 commit comments

Comments
 (0)