openSubsonicExtensions shape is not representable in XML

[sentriz]

hey, have we thought about the openSubsonicExtensions response shape in XML? to me it looks like it's not possible to 1-1 translate it. (related, the shape in Go is map[string][]int, which the Go xml marshaler will error on)

[Tolriq]

I did not, but since the first one is not yet validated we can still rework that. I guess extension being an object too?

[ { "name": "transcodeOffset", "versions" : [ 1 ] }, { "name": "template", "versions" : [ 1, 3 ] }]

[sentriz]

yes, that looks like it works for both 👍

---snip---

[Tolriq]

According to XML standard no it seems it's not allowed to have multiple attribute name with the same name. The versions should be a list inside the openSubsonicExtensions element.

[sentriz]

@Tolriq did you see my comment above? it is valid XML, and we do exactly this for the search3 endpoint for example

[spl0k]

Your last comment show tags, which is indeed allowed. I'm talking about attributes which are the name="value" within tags. Your first comment shows multiple versions attributes.

[sentriz]

oh the attributes! sorry my mistake

in that case, adjusting the type

{
 "subsonic-response": {
  "status": "ok",
  "version": "1.15.0",
  "type": "gonic",
  "serverVersion": "0.15.2",
  "openSubsonic": true,
  "openSubsonicExtensions": [
   { "name": "someExample", "versions": [ 1, 2, 3 ] },
   { "name": "transcodeOffset", "versions": [ 1 ] }
  ]
 }
}

<subsonic-response status="ok" version="1.15.0" xmlns="http://subsonic.org/restapi" type="gonic" serverVersion="0.15.2" openSubsonic="true">
 <openSubsonicExtensions name="someExample">
  <versions>1</versions>
  <versions>2</versions>
  <versions>3</versions>
 </openSubsonicExtensions>
 <openSubsonicExtensions name="transcodeOffset">
  <versions>1</versions>
 </openSubsonicExtensions>
</subsonic-response>

type OpenSubsonicExtension struct {
	Name     string `xml:"name,attr" json:"name"`
	Versions []int  `xml:"versions"  json:"versions"`
}

type OpenSubsonicExtensions []OpenSubsonicExtension

[Tolriq]

I've updated the PR.