Apply linting fixes and update documentation

- Fix Terraform formatting in cloud-run.tf and locals.tf
- Remove trailing whitespace from scripts and docs
- Add missing newlines at end of files
- Update README with app_command variable documentation
- Make container command configurable with default ['serve']

Author: dcmcand

README.md

@@ -196,16 +196,19 @@ No modules.
 | [google_sql_database_instance.main](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_database_instance) | resource |
 | [google_sql_user.main](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_user) | resource |
 | [google_vpc_access_connector.main](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/vpc_access_connector) | resource |
+| [random_id.network_suffix](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/id) | resource |
 | [random_password.db_password](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password) | resource |
 
 ## Inputs
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
 | <a name="input_ai_api_keys"></a> [ai\_api\_keys](#input\_ai\_api\_keys) | Map of AI API keys where key is the environment variable name (e.g., OPENAI\_API\_KEY, ANTHROPIC\_API\_KEY) and value is the actual API key (stored in Secret Manager) | `map(string)` | `{}` | no |
+| <a name="input_app_command"></a> [app\_command](#input\_app\_command) | Command to run the container | `list(string)` | <pre>[<br/>  "serve"<br/>]</pre> | no |
 | <a name="input_app_cpu"></a> [app\_cpu](#input\_app\_cpu) | CPU allocation for the hrafnar application | `string` | `"1000m"` | no |
 | <a name="input_app_env_vars"></a> [app\_env\_vars](#input\_app\_env\_vars) | Environment variables for the hrafnar application | `map(string)` | `{}` | no |
-| <a name="input_app_image"></a> [app\_image](#input\_app\_image) | Container image for the hrafnar application | `string` | n/a | yes |
+| <a name="input_app_image"></a> [app\_image](#input\_app\_image) | Container image for the hrafnar application (without tag) | `string` | n/a | yes |
+| <a name="input_app_image_tag"></a> [app\_image\_tag](#input\_app\_image\_tag) | Container image tag | `string` | `"latest"` | no |
 | <a name="input_app_max_instances"></a> [app\_max\_instances](#input\_app\_max\_instances) | Maximum number of instances for the hrafnar application | `number` | `10` | no |
 | <a name="input_app_memory"></a> [app\_memory](#input\_app\_memory) | Memory allocation for the hrafnar application | `string` | `"512Mi"` | no |
 | <a name="input_app_min_instances"></a> [app\_min\_instances](#input\_app\_min\_instances) | Minimum number of instances for the hrafnar application | `number` | `0` | no |
@@ -228,7 +231,7 @@ No modules.
 | <a name="input_log_level"></a> [log\_level](#input\_log\_level) | Log level for applications | `string` | `"INFO"` | no |
 | <a name="input_mcp_servers"></a> [mcp\_servers](#input\_mcp\_servers) | MCP server configurations | <pre>map(object({<br/>    url         = string<br/>    api_key     = optional(string)<br/>    description = string<br/>  }))</pre> | `{}` | no |
 | <a name="input_name_prefix"></a> [name\_prefix](#input\_name\_prefix) | Prefix for resource naming | `string` | n/a | yes |
-| <a name="input_private_subnet_cidr"></a> [private\_subnet\_cidr](#input\_private\_subnet\_cidr) | CIDR block for the private subnet | `string` | `"10.0.1.0/24"` | no |
+| <a name="input_private_subnet_cidr"></a> [private\_subnet\_cidr](#input\_private\_subnet\_cidr) | CIDR block for the private subnet (must be /28 for VPC connector compatibility) | `string` | `"10.0.1.0/28"` | no |
 | <a name="input_project_id"></a> [project\_id](#input\_project\_id) | The GCP project ID where resources will be created | `string` | n/a | yes |
 | <a name="input_region"></a> [region](#input\_region) | The GCP region for resources | `string` | `"us-central1"` | no |
 | <a name="input_vpc_cidr"></a> [vpc\_cidr](#input\_vpc\_cidr) | CIDR block for the VPC | `string` | `"10.0.0.0/16"` | no |

cloud-run.tf

@@ -26,6 +26,8 @@ resource "google_cloud_run_service" "main_app" {
       containers {
         image = "${var.app_image}:${var.app_image_tag}"
 
+        command = var.app_command
+
         ports {
           container_port = var.app_port
         }

docs/ARTIFACT_REGISTRY_SETUP.md

@@ -64,12 +64,12 @@ Update your module configuration:
 ```hcl
 module "hrafnar_deploy" {
   source = "../.."
-  
+
   project_id    = "your-project-id"
   name_prefix   = "my-app"
   app_image     = "us-central1-docker.pkg.dev/your-project-id/quay-remote/reiemp/hrafnar"
   app_image_tag = "latest"
-  
+
   # ... other configuration
 }
 ```
@@ -111,4 +111,4 @@ If the quay.io repository requires authentication:
 ### Performance
 - First pull will be slower as it fetches from quay.io
 - Subsequent pulls use the cached version in Artifact Registry
-- Configure cleanup policies to manage storage costs
+- Configure cleanup policies to manage storage costs

examples/dev/README.md

@@ -123,4 +123,4 @@ module "hrafnar_gcp_deploy" {
 | <a name="output_database_connection_name"></a> [database\_connection\_name](#output\_database\_connection\_name) | Development database connection name |
 | <a name="output_hrafnar_app_url"></a> [hrafnar\_app\_url](#output\_hrafnar\_app\_url) | URL of the hrafnar application in development |
 | <a name="output_vpc_name"></a> [vpc\_name](#output\_vpc\_name) | Development VPC network name |
-<!-- END_TF_DOCS -->
+<!-- END_TF_DOCS -->

locals.tf

@@ -35,7 +35,7 @@ locals {
   router_name         = "${local.resource_prefix}-router-${random_id.network_suffix.hex}"
   # VPC connector name must be <= 25 chars and match ^[a-z][-a-z0-9]{0,23}[a-z0-9]$
   # Add random suffix to avoid naming collisions
-  vpc_connector_name  = length("${local.resource_prefix}-conn-${random_id.network_suffix.hex}") <= 25 ? "${local.resource_prefix}-conn-${random_id.network_suffix.hex}" : "${substr(local.resource_prefix, 0, 11)}-conn-${random_id.network_suffix.hex}"
+  vpc_connector_name = length("${local.resource_prefix}-conn-${random_id.network_suffix.hex}") <= 25 ? "${local.resource_prefix}-conn-${random_id.network_suffix.hex}" : "${substr(local.resource_prefix, 0, 11)}-conn-${random_id.network_suffix.hex}"
 
   # Cloud Run service names
   main_app_service_name = "${local.resource_prefix}-app"

scripts/setup-artifact-registry.sh

@@ -37,7 +37,7 @@ else
         --description="Remote repository for quay.io images" \
         --remote-docker-repo=https://quay.io \
         --project="$PROJECT_ID"
-    
+
     echo "Repository created successfully!"
 fi
 
@@ -50,4 +50,4 @@ echo "  New:      ${REGION}-docker.pkg.dev/${PROJECT_ID}/${REPOSITORY_ID}/reiemp
 echo ""
 echo "Example in Terraform:"
 echo "  app_image = \"${REGION}-docker.pkg.dev/${PROJECT_ID}/${REPOSITORY_ID}/reiemp/hrafnar\""
-echo "  app_image_tag = \"latest\""
+echo "  app_image_tag = \"latest\""

variables.tf

@@ -99,6 +99,12 @@ variable "app_port" {
   default     = 8080
 }
 
+variable "app_command" {
+  description = "Command to run the container"
+  type        = list(string)
+  default     = ["serve"]
+}
+
 variable "app_cpu" {
   description = "CPU allocation for the hrafnar application"
   type        = string