Add random suffix to network resources to prevent naming collisions

- Add random_id resource for network naming
- Apply random suffix to VPC, subnet, NAT gateway, router, and VPC connector names
- This prevents conflicts with existing resources from previous test runs

Author: dcmcand

locals.tf

@@ -1,3 +1,8 @@
+# Random suffix for network resources to avoid naming collisions
+resource "random_id" "network_suffix" {
+  byte_length = 4
+}
+
 locals {
   # Resource naming
   resource_prefix = var.name_prefix
@@ -23,13 +28,14 @@ locals {
   # Service account names
   app_service_account = "${local.resource_prefix}-app"
 
-  # Network names
-  vpc_name            = "${local.resource_prefix}-vpc"
-  private_subnet_name = "${local.resource_prefix}-private-subnet"
-  nat_gateway_name    = "${local.resource_prefix}-nat-gateway"
-  router_name         = "${local.resource_prefix}-router"
+  # Network names with random suffix to avoid naming collisions
+  vpc_name            = "${local.resource_prefix}-vpc-${random_id.network_suffix.hex}"
+  private_subnet_name = "${local.resource_prefix}-subnet-${random_id.network_suffix.hex}"
+  nat_gateway_name    = "${local.resource_prefix}-nat-${random_id.network_suffix.hex}"
+  router_name         = "${local.resource_prefix}-router-${random_id.network_suffix.hex}"
   # VPC connector name must be <= 25 chars and match ^[a-z][-a-z0-9]{0,23}[a-z0-9]$
-  vpc_connector_name  = length("${local.resource_prefix}-connector") <= 25 ? "${local.resource_prefix}-connector" : "${substr(local.resource_prefix, 0, 15)}-connector"
+  # Add random suffix to avoid naming collisions
+  vpc_connector_name  = length("${local.resource_prefix}-conn-${random_id.network_suffix.hex}") <= 25 ? "${local.resource_prefix}-conn-${random_id.network_suffix.hex}" : "${substr(local.resource_prefix, 0, 11)}-conn-${random_id.network_suffix.hex}"
 
   # Cloud Run service names
   main_app_service_name = "${local.resource_prefix}-app"