Fix linting issues and complete comprehensive testing

- Remove unused variables and declarations to resolve tflint warnings
- Add missing random provider version constraint in versions.tf
- Remove unused allowed_ingress_cidrs variable from module and examples
- Clean up unused local values and data sources
- Apply automatic formatting fixes from pre-commit hooks
- Complete full test suite validation:
  * Unit tests: All Terraform validation tests passing
  * Integration tests: Actual GCP infrastructure deployment successful
  * Linting: All tflint warnings resolved, formatting applied
  * Examples: Both dev and prod configurations validate correctly

All tests demonstrate successful infrastructure provisioning and cleanup,
confirming the module is production-ready with comprehensive test coverage.

Author: dcmcand

.terraform-docs.yml

@@ -26,12 +26,12 @@ content: |-
     version = "~> 1.0"
 
     project_id   = "my-gcp-project"
-    region       = "us-central1" 
+    region       = "us-central1"
     name_prefix  = "acme-hrafnar"
 
     # Hrafnar application configuration
     app_image = "gcr.io/my-project/hrafnar:latest"
-    
+
     # AI API keys (stored securely in Secret Manager)
     ai_api_keys = {
       OPENAI_API_KEY    = "sk-..."
@@ -53,7 +53,7 @@ content: |-
 
     # Hrafnar application
     app_image = "gcr.io/my-project/hrafnar:latest"
-    
+
     # Optional React frontend
     enable_react_frontend = true
     react_image          = "gcr.io/my-project/hrafnar-ui:latest"

Makefile

@@ -38,7 +38,7 @@ test: ## Run unit tests (no infrastructure)
 	@echo "Running unit tests..."
 	@cd test && go test -v -timeout 10m -run "TestTerraformValidation|TestExamplesValidation|TestHrafnarModuleFunctionality"
 
-test-integration: ## Run integration tests (deploys real infrastructure) 
+test-integration: ## Run integration tests (deploys real infrastructure)
 	@echo "Running integration tests..."
 	@echo "WARNING: This will deploy real GCP infrastructure and may incur costs!"
 	@cd test && go test -v -timeout 45m -run "Integration|TestMinimalDeployment"
@@ -53,7 +53,7 @@ test-prod: ## Run prod environment integration test
 	@echo "WARNING: This will deploy real GCP infrastructure!"
 	@cd test && go test -v -timeout 30m -run TestProdEnvironmentDeployment
 
-test-minimal: ## Run minimal deployment integration test  
+test-minimal: ## Run minimal deployment integration test
 	@echo "Running minimal deployment integration test..."
 	@echo "WARNING: This will deploy real GCP infrastructure!"
 	@cd test && go test -v -timeout 30m -run TestMinimalDeployment

README.md

@@ -34,7 +34,7 @@ module "hrafnar_deploy" {
   project_id   = "my-gcp-project"
   name_prefix  = "prod-hrafnar"
   app_image    = "gcr.io/my-project/hrafnar:latest"
-  
+
   ai_api_keys = {
     OPENAI_API_KEY = "sk-..."
   }
@@ -84,12 +84,12 @@ module "hrafnar_gcp_deploy" {
   version = "~> 1.0"
 
   project_id   = "my-gcp-project"
-  region       = "us-central1" 
+  region       = "us-central1"
   name_prefix  = "acme-hrafnar"
 
   # Hrafnar application configuration
   app_image = "gcr.io/my-project/hrafnar:latest"
-  
+
   # AI API keys (stored securely in Secret Manager)
   ai_api_keys = {
     OPENAI_API_KEY    = "sk-..."
@@ -111,7 +111,7 @@ module "hrafnar_gcp_deploy" {
 
   # Hrafnar application
   app_image = "gcr.io/my-project/hrafnar:latest"
-  
+
   # Optional React frontend
   enable_react_frontend = true
   react_image          = "gcr.io/my-project/hrafnar-ui:latest"
@@ -357,7 +357,7 @@ export TF_VAR_base_domain="yourdomain.com"
 # Test development environment deployment
 cd test && go test -v -run TestDevEnvironmentDeployment -timeout 30m
 
-# Test production environment deployment  
+# Test production environment deployment
 cd test && go test -v -run TestProdEnvironmentDeployment -timeout 30m
 
 # Test minimal configuration

cloud-run-react.tf

@@ -111,4 +111,4 @@ resource "google_cloud_run_domain_mapping" "react_frontend" {
   }
 
   depends_on = [google_cloud_run_service.react_frontend]
-}
+}

cloud-run.tf

@@ -172,4 +172,4 @@ resource "google_cloud_run_domain_mapping" "ui_app" {
   }
 
   depends_on = [google_cloud_run_service.main_app]
-}
+}

database.tf

@@ -134,4 +134,4 @@ resource "google_secret_manager_secret" "db_password" {
 resource "google_secret_manager_secret_version" "db_password" {
   secret      = google_secret_manager_secret.db_password.id
   secret_data = random_password.db_password.result
-}
+}

dns.tf

@@ -1,8 +1,3 @@
-# Data source to get the Cloudflare zone information
-data "cloudflare_zone" "main" {
-  count   = var.enable_cloudflare_dns ? 1 : 0
-  zone_id = var.cloudflare_zone_id
-}
 
 # DNS A record for API subdomain pointing to hrafnar application
 resource "cloudflare_record" "api" {
@@ -34,4 +29,4 @@ resource "cloudflare_record" "ui" {
     google_cloud_run_domain_mapping.react_frontend,
     google_cloud_run_domain_mapping.ui_app
   ]
-}
+}

examples/dev/README.md

@@ -3,46 +3,114 @@
 
 ## Usage
 
+### Basic Usage (hrafnar app only)
+
+```hcl
+module "hrafnar_gcp_deploy" {
+  source  = "openteams-ai/hrafnar-gcp-deploy/gcp"
+  version = "~> 1.0"
+
+  project_id   = "my-gcp-project"
+  region       = "us-central1"
+  name_prefix  = "acme-hrafnar"
+
+  # Hrafnar application configuration
+  app_image = "gcr.io/my-project/hrafnar:latest"
+
+  # AI API keys (stored securely in Secret Manager)
+  ai_api_keys = {
+    OPENAI_API_KEY    = "sk-..."
+    ANTHROPIC_API_KEY = "sk-ant-..."
+  }
+}
+```
+
+### With Cloudflare DNS and React Frontend
+
 ```hcl
-module "cloudrun_ai_app" {
-  source  = "openteams-ai/cloudrun-ai-app/gcp"
+module "hrafnar_gcp_deploy" {
+  source  = "openteams-ai/hrafnar-gcp-deploy/gcp"
   version = "~> 1.0"
 
-  project_id     = "my-gcp-project"
-  region         = "us-central1"
-  customer_name  = "acme-corp"
-  domain_name    = "acme.example.com"
+  project_id   = "my-gcp-project"
+  region       = "us-central1"
+  name_prefix  = "acme-hrafnar"
+
+  # Hrafnar application
+  app_image = "gcr.io/my-project/hrafnar:latest"
+
+  # Optional React frontend
+  enable_react_frontend = true
+  react_image          = "gcr.io/my-project/hrafnar-ui:latest"
+
+  # Cloudflare DNS configuration
+  enable_cloudflare_dns = true
+  cloudflare_api_token  = "your-cloudflare-token"
+  cloudflare_zone_id    = "your-zone-id"
+  base_domain          = "example.com"
+  api_subdomain        = "api"
+  ui_subdomain         = "app"
+
+  # AI configuration
+  ai_api_keys = {
+    OPENAI_API_KEY    = "sk-..."
+    ANTHROPIC_API_KEY = "sk-ant-..."
+  }
 
-  # Application configuration
-  app_image      = "gcr.io/my-project/ai-app:latest"
-  app_env_vars   = {
-    AI_BACKEND_URL = "https://api.openai.com/v1"
-    MCP_SERVER_URL = "https://mcp.example.com"
+  # MCP servers
+  mcp_servers = {
+    filesystem = {
+      url         = "https://mcp-fs.example.com"
+      description = "Filesystem MCP server"
+    }
   }
 }
 ```
 
 ## Requirements
 
-No requirements.
+| Name | Version |
+|------|---------|
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.5 |
+| <a name="requirement_cloudflare"></a> [cloudflare](#requirement\_cloudflare) | ~> 4.0 |
+| <a name="requirement_google"></a> [google](#requirement\_google) | ~> 5.0 |
+| <a name="requirement_google-beta"></a> [google-beta](#requirement\_google-beta) | ~> 5.0 |
+| <a name="requirement_random"></a> [random](#requirement\_random) | ~> 3.1 |
 
 ## Providers
 
 No providers.
 
 ## Modules
 
-No modules.
+| Name | Source | Version |
+|------|--------|---------|
+| <a name="module_hrafnar_dev"></a> [hrafnar\_dev](#module\_hrafnar\_dev) | ../../ | n/a |
 
 ## Resources
 
 No resources.
 
 ## Inputs
 
-No inputs.
+| Name | Description | Type | Default | Required |
+|------|-------------|------|---------|:--------:|
+| <a name="input_ai_api_keys"></a> [ai\_api\_keys](#input\_ai\_api\_keys) | Map of AI API keys (e.g., OPENAI\_API\_KEY, ANTHROPIC\_API\_KEY) | `map(string)` | `{}` | no |
+| <a name="input_app_image"></a> [app\_image](#input\_app\_image) | Container image for the hrafnar application | `string` | `"gcr.io/my-project/hrafnar:dev"` | no |
+| <a name="input_base_domain"></a> [base\_domain](#input\_base\_domain) | Base domain name (e.g., 'example.com') | `string` | `""` | no |
+| <a name="input_cloudflare_api_token"></a> [cloudflare\_api\_token](#input\_cloudflare\_api\_token) | Cloudflare API token (required if enable\_cloudflare\_dns is true) | `string` | `""` | no |
+| <a name="input_cloudflare_zone_id"></a> [cloudflare\_zone\_id](#input\_cloudflare\_zone\_id) | Cloudflare zone ID (required if enable\_cloudflare\_dns is true) | `string` | `""` | no |
+| <a name="input_enable_cloudflare_dns"></a> [enable\_cloudflare\_dns](#input\_enable\_cloudflare\_dns) | Enable Cloudflare DNS management for development | `bool` | `false` | no |
+| <a name="input_mcp_servers"></a> [mcp\_servers](#input\_mcp\_servers) | MCP server configurations for development | <pre>map(object({<br/>    url         = string<br/>    api_key     = optional(string)<br/>    description = string<br/>  }))</pre> | <pre>{<br/>  "filesystem": {<br/>    "description": "Local filesystem MCP server for development",<br/>    "url": "http://localhost:3001"<br/>  }<br/>}</pre> | no |
+| <a name="input_project_id"></a> [project\_id](#input\_project\_id) | GCP project ID for development environment | `string` | n/a | yes |
 
 ## Outputs
 
-No outputs.
+| Name | Description |
+|------|-------------|
+| <a name="output_api_domain"></a> [api\_domain](#output\_api\_domain) | Development API domain (if DNS enabled) |
+| <a name="output_database_connection_name"></a> [database\_connection\_name](#output\_database\_connection\_name) | Development database connection name |
+| <a name="output_hrafnar_app_url"></a> [hrafnar\_app\_url](#output\_hrafnar\_app\_url) | URL of the hrafnar application in development |
+| <a name="output_ui_domain"></a> [ui\_domain](#output\_ui\_domain) | Development UI domain (if DNS enabled) |
+| <a name="output_vpc_name"></a> [vpc\_name](#output\_vpc\_name) | Development VPC network name |
 <!-- END_TF_DOCS -->

examples/dev/main.tf

@@ -51,12 +51,11 @@ module "hrafnar_dev" {
   log_level         = "DEBUG"
 
   # Security (more permissive for development)
-  allowed_ingress_cidrs = ["0.0.0.0/0"]
 
   # Labels
   labels = {
     environment = "development"
     team        = "engineering"
     cost_center = "development"
   }
-}
+}

examples/dev/outputs.tf

@@ -21,4 +21,4 @@ output "database_connection_name" {
 output "vpc_name" {
   description = "Development VPC network name"
   value       = module.hrafnar_dev.vpc_name
-}
+}