Skip to content

docs: optimize algolia search style #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

docs: optimize algolia search style #2605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions examples/sites/src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,12 @@ b, strong {
position: absolute;
z-index: 1000;
top: 12px;
left: 360px;
left: 210px;
}

.DocSearch-Container {
z-index: 1000;
font-size: 14px;
}

.DocSearch-Button {
Expand All @@ -62,9 +63,9 @@ b, strong {
--docsearch-searchbox-background: #f5f5f5;
}

@media screen and (max-width: 1023px) {
@media screen and (max-width: 814px) {
.search-box {
left: 420px;
left: 230px;
}
Comment on lines +66 to 69
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Breakpoint 814px appears inconsistent with design system

The codebase shows a clear pattern of standard breakpoints at 1023px, 768px, and other common values. The 814px breakpoint in the reviewed file appears to be an outlier, especially when compared to the design system's breakpoint at 815px in design-common.css. This suggests a potential misalignment that should be corrected.

  • Consider aligning the 814px breakpoint with the design system's 815px breakpoint in examples/sites/public/static/css/design-common.css
  • The change from 1023px to 814px represents a significant shift that doesn't align with the common breakpoints used across the codebase (768px, 815px, 1023px, 1279px, 1339px)
🔗 Analysis chain

Verify alignment with design system breakpoints

The breakpoint has been changed from 1023px to 814px. Please ensure this aligns with the design system's standard breakpoints.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistent breakpoint usage

# Look for other breakpoint definitions
rg -A 2 '@media.*max-width' --type css

Length of output: 1829

}

Expand All @@ -74,12 +75,6 @@ b, strong {
}

.search-box {
left: 360px;
left: 230px;
}
}

@media screen and (max-width: 430px) {
.search-box {
left: 300px;
}
}
Loading