Skip to content

Commit 4bcc63b

Browse files
authored
prevent null value serialization in JwtSigner (#331)
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
1 parent da02309 commit 4bcc63b

File tree

1 file changed

+7
-2
lines changed
  • src/WalletFramework.SdJwtVc/Services/SdJwtVcHolderService

1 file changed

+7
-2
lines changed

src/WalletFramework.SdJwtVc/Services/SdJwtVcHolderService/SdJwtSigner.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,13 @@ public async Task<string> GenerateKbProofOfPossessionAsync(
6363

6464
public async Task<string> CreateSignedJwt(object header, object payload, KeyId keyId)
6565
{
66-
var encodedHeader = Base64UrlEncoder.Encode(JsonConvert.SerializeObject(header));
67-
var encodedPayload = Base64UrlEncoder.Encode(JsonConvert.SerializeObject(payload));
66+
var serializerSettings = new JsonSerializerSettings
67+
{
68+
NullValueHandling = NullValueHandling.Ignore
69+
};
70+
71+
var encodedHeader = Base64UrlEncoder.Encode(JsonConvert.SerializeObject(header, serializerSettings));
72+
var encodedPayload = Base64UrlEncoder.Encode(JsonConvert.SerializeObject(payload, serializerSettings));
6873

6974
var dataToSign = encodedHeader + "." + encodedPayload;
7075
var signature = await keyStore.Sign(keyId, Encoding.UTF8.GetBytes(dataToSign));

0 commit comments

Comments
 (0)