Skip to content

Commit 78050f1

Browse files
karupayunchsigg
authored andcommitted
Remove LLVM_ABI_BREAKING_CHECKS=FORCE_OFF.
The issue raised in triton-lang#4212 (comment) and temporary fixed in triton-lang#4512 has now been fixed upstream. The non-deterministic seed inside the hashing function (included in this llvm commit: llvm/llvm-project@ce80c80) was disabled for clang <= 11 for non-pic builds. This was removed again in xgupta/llvm-project@5255b81 and we can enable ABI-breaking checks again. We build LLVM with PIC. If anyone ever builds with non-PIC, they will get a compilation error and need to disable LLVM_ABI_BREAKING_CHECKS manually.
1 parent ab07e54 commit 78050f1

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

.github/workflows/llvm-build.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ jobs:
107107
-DLLVM_INSTALL_UTILS=ON
108108
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU"
109109
-DLLVM_ENABLE_TERMINFO=OFF
110-
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF
111110
llvm-project/llvm
112111
113112
ninja -C llvm-project/build check-mlir install
@@ -131,7 +130,6 @@ jobs:
131130
-DLLVM_INSTALL_UTILS=ON
132131
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU"
133132
-DLLVM_ENABLE_TERMINFO=OFF
134-
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF
135133
llvm-project/llvm
136134
137135
ninja -C llvm-project/build check-mlir install

.github/workflows/llvm-build/almalinux.Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ RUN cmake -GNinja -Bbuild \
3333
-DLLVM_ENABLE_PROJECTS=mlir \
3434
-DLLVM_ENABLE_TERMINFO=OFF \
3535
-DLLVM_INSTALL_UTILS=ON \
36-
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF \
3736
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU" \
3837
/source/llvm-project/llvm
3938

cmake/llvm-hash.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
61f8a7f618901797ee8663389a29722f29216a96
1+
5255b819c1b117e6048f354c035f5d36f3afad2b

0 commit comments

Comments
 (0)