Skip to content

Publish for macOS #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kelson42 opened this issue Mar 2, 2020 · 4 comments · Fixed by #43
Closed

Publish for macOS #32

kelson42 opened this issue Mar 2, 2020 · 4 comments · Fixed by #43
Assignees
@bakshiutkarsha
Labels
enhancement

Comments

@kelson42
Copy link
Contributor

kelson42 commented Mar 2, 2020

Currently we publish for GNU/Linux only.
@kelson42
Copy link
Contributor Author

kelson42 commented Mar 2, 2020

Depends on kiwix/kiwix-build#349

@kelson42 kelson42 pinned this issue Mar 2, 2020
@kelson42 kelson42 mentioned this issue Mar 2, 2020
Closed
@pirate pirate mentioned this issue Apr 17, 2020
Merged
5 tasks
@kelson42
Copy link
Contributor Author

We have now the binaries for macOS published, see https://download.openzim.org/release/libzim/libzim_macos-x86_64-6.1.6.tar.gz for example

@kelson42
Copy link
Contributor Author

@bakshiutkarsha If you read my comment just above, you can understand that now everything is ready to add macOS support to node-libzim. This is a really important point as many javascript/nodejs developer use macOS to work, like you. I think as well as this should be relatively easy to add macOS support considering that we have already working for GNU/Linux, even if we deal here with native stuff. I believe this is as well a good thing to learn/know for you: writting n-api bindings. I would like you to invite you to implement this ticket.

@bakshiutkarsha
Copy link
Contributor

@kelson42 Yes it would be a good learning experience for me and would be beneficial to all JS contributors(for macOS). I can take up this ticket.

@bakshiutkarsha bakshiutkarsha mentioned this issue Jul 5, 2020
Merged
@kelson42 kelson42 unpinned this issue Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bakshiutkarsha bakshiutkarsha

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mac publishing changes openzim/node-libzim
2 participants
@kelson42 @bakshiutkarsha