Skip to content

Add getMainPage and setter the Creator wrapper #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdcaballerov opened this issue Apr 9, 2020 · 1 comment
Closed

Add getMainPage and setter the Creator wrapper #6

jdcaballerov opened this issue Apr 9, 2020 · 1 comment

Comments

@jdcaballerov
Copy link
Contributor

Probably upstream limitation but requiring main_page on ZimCreator creation seems weird. You allow to set it to blank but can't change it afterwards?

I used the same construct as node-libzim that fixes it from creation.
ZimCreator must implement a function getMainPage so that when finishZimCreation() (C++) is called the header is filled with it fillHeader().

With the current design I can overload the wrapper function and add a setter if needed.

I think it makes sense, yes.

@jdcaballerov
Copy link
Contributor Author

Commit 9e45d5c Adds the feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant