fix: if there are no changes, they should not be on the ignore list

metacosm · metacosm · commit a5cfd6eeeea3 · 2023-05-03T12:32:52.000+02:00
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/GenericKubernetesResourceMatcher.java
@@ -174,7 +174,7 @@ private static boolean allDiffsAreAddOps(List<JsonNode> metadataJSonDiffs) {
   private static boolean allDiffsOnIgnoreList(List<JsonNode> metadataJSonDiffs,
       List<String> ignoreList) {
     if (metadataJSonDiffs.isEmpty()) {
-      return true;
+      return false;
     }
     return metadataJSonDiffs.stream().allMatch(n -> {
       var path = n.get("path").asText();

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ private static boolean allDiffsAreAddOps(List<JsonNode> metadataJSonDiffs) {`
`174`	`174`	`private static boolean allDiffsOnIgnoreList(List<JsonNode> metadataJSonDiffs,`
`175`	`175`	`List<String> ignoreList) {`
`176`	`176`	`if (metadataJSonDiffs.isEmpty()) {`
`177`		`- return true;`
	`177`	`+ return false;`
`178`	`178`	`}`
`179`	`179`	`return metadataJSonDiffs.stream().allMatch(n -> {`
`180`	`180`	`var path = n.get("path").asText();`