Go operator doesn't shutdown gracefully on SIGTERM

[ghost]

Bug Report

The operator terminates immediately on SIGTERM
What did you do?
Start the built operator and press CTRL+C

What did you expect to see?
The operator wait for all reconcile loops to finish and then exit

What did you see instead? Under which circumstances?
The operators exits immediately interrupting the ongoing reconciles which leaves my kubernetes cluster in a dangling state.

Environment

• operator-sdk version:
  0.9.0

[theishshah]

That is the expected behaviour for SIGINT (Control + C). SIGTERM and SIGINT are generally not handled by the operator and are expected to exit without clean up.

[joelanford]

Actually, I think this is supposed to be handled by controller-runtime's signal handler (which SDK uses), but there's a bug that causes the manager to return before the Runnables have stopped.

See kubernetes-sigs/controller-runtime#350

We'll pick this fix up when it makes it into a controller-runtime release.

[RobEarl]

Does kubernetes-sigs/controller-runtime#967 allow this to progress?