Skip to content

Commit afeaa10

Browse files
fearlessfeGrapeBaBa
authored andcommitted
feat: change flag name
1 parent 2b6c5eb commit afeaa10

File tree

3 files changed

+34
-34
lines changed

3 files changed

+34
-34
lines changed

cmd/shisui/config_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ import (
99
)
1010

1111
func TestGenConfig(t *testing.T) {
12-
size := uint64(1000 * 1000)
12+
size := uint64(5 * 1000 * 1000 * 1000)
1313
flagSet := flag.NewFlagSet("test", 0)
14-
flagSet.String("history.http.addr", "127.0.0.11", "test")
15-
flagSet.String("history.http.port", "8888", "test")
16-
flagSet.String("history.data.dir", "./test", "test")
17-
flagSet.Uint64("history.data.capacity", size, "test")
14+
flagSet.String("rpc.addr", "127.0.0.11", "test")
15+
flagSet.String("rpc.port", "8888", "test")
16+
flagSet.String("data.dir", "./test", "test")
17+
flagSet.Uint64("data.capacity", size, "test")
1818
flagSet.String("udp.addr", "172.23.50.11", "test")
1919
flagSet.Int("udp.port", 9999, "test")
20-
flagSet.Int("history.loglevel", 3, "test")
20+
flagSet.Int("loglevel", 3, "test")
2121

2222
command := &cli.Command{Name: "mycommand"}
2323

cmd/shisui/main.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ var app = flags.NewApp("the go-portal-network command line interface")
3434

3535
var (
3636
portalProtocolFlags = []cli.Flag{
37-
utils.ProtocolUDPListenAddrFlag,
38-
utils.ProtocolUDPPortFlag,
37+
utils.PortalUDPListenAddrFlag,
38+
utils.PortalUDPPortFlag,
3939
}
4040
historyRpcFlags = []cli.Flag{
41-
utils.HistoryHTTPListenAddrFlag,
42-
utils.HistoryHTTPPortFlag,
43-
utils.HistoryDataDirFlag,
44-
utils.HistoryDataCapacityFlag,
45-
utils.LogLevelFlag,
41+
utils.PortalRPCListenAddrFlag,
42+
utils.PortalRPCPortFlag,
43+
utils.PortalDataDirFlag,
44+
utils.PortalDataCapacityFlag,
45+
utils.PortalLogLevelFlag,
4646
}
4747
hiveTestFlags = []cli.Flag{
4848
utils.HiveBootNodeFlag,
@@ -118,21 +118,21 @@ func getPortalHistoryConfig(ctx *cli.Context) (*PortalHistoryConfig, error) {
118118
return config, err
119119
}
120120

121-
httpAddr := ctx.String(utils.HistoryHTTPListenAddrFlag.Name)
122-
httpPort := ctx.String(utils.HistoryHTTPPortFlag.Name)
121+
httpAddr := ctx.String(utils.PortalRPCListenAddrFlag.Name)
122+
httpPort := ctx.String(utils.PortalRPCPortFlag.Name)
123123
config.RpcAddr = net.JoinHostPort(httpAddr, httpPort)
124-
config.DataDir = ctx.String(utils.HistoryDataDirFlag.Name)
125-
config.DataCapacity = ctx.Uint64(utils.HistoryDataCapacityFlag.Name)
126-
config.LogLevel = ctx.Int(utils.LogLevelFlag.Name)
127-
port := ctx.String(utils.ProtocolUDPPortFlag.Name)
124+
config.DataDir = ctx.String(utils.PortalDataDirFlag.Name)
125+
config.DataCapacity = ctx.Uint64(utils.PortalDataCapacityFlag.Name)
126+
config.LogLevel = ctx.Int(utils.PortalLogLevelFlag.Name)
127+
port := ctx.String(utils.PortalUDPPortFlag.Name)
128128
if !strings.HasPrefix(port, ":") {
129129
config.Protocol.ListenAddr = ":" + port
130130
} else {
131131
config.Protocol.ListenAddr = port
132132
}
133133

134-
if ctx.IsSet(utils.ProtocolUDPListenAddrFlag.Name) {
135-
ip := ctx.String(utils.ProtocolUDPListenAddrFlag.Name)
134+
if ctx.IsSet(utils.PortalUDPListenAddrFlag.Name) {
135+
ip := ctx.String(utils.PortalUDPListenAddrFlag.Name)
136136
netIp := net.ParseIP(ip)
137137
if netIp == nil {
138138
return config, fmt.Errorf("invalid ip addr: %s", ip)

cmd/utils/flags.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -945,50 +945,50 @@ Please note that --` + MetricsHTTPFlag.Name + ` must be set to start the server.
945945
Category: flags.MetricsCategory,
946946
}
947947

948-
HistoryHTTPListenAddrFlag = &cli.StringFlag{
949-
Name: "history.http.addr",
948+
PortalRPCListenAddrFlag = &cli.StringFlag{
949+
Name: "rpc.addr",
950950
Usage: "HTTP-RPC server listening interface",
951951
Value: node.DefaultHTTPHost,
952952
Category: flags.PortalNetworkCategory,
953953
}
954954

955-
HistoryHTTPPortFlag = &cli.IntFlag{
956-
Name: "history.http.port",
955+
PortalRPCPortFlag = &cli.IntFlag{
956+
Name: "rpc.port",
957957
Usage: "HTTP-RPC server listening port",
958958
Value: node.DefaultHTTPPort,
959959
Category: flags.PortalNetworkCategory,
960960
}
961961

962-
HistoryDataDirFlag = &cli.StringFlag{
963-
Name: "history.data.dir",
962+
PortalDataDirFlag = &cli.StringFlag{
963+
Name: "data.dir",
964964
Usage: "data dir of where the data file located",
965965
Value: "./",
966966
Category: flags.PortalNetworkCategory,
967967
}
968968

969-
HistoryDataCapacityFlag = &cli.Uint64Flag{
970-
Name: "history.data.capacity",
969+
PortalDataCapacityFlag = &cli.Uint64Flag{
970+
Name: "data.capacity",
971971
Usage: "the capacity of the data stored, the unit is byte",
972-
Value: 1000 * 1000 * 1000, // 1 GB
972+
Value: 1000 * 1000 * 1000 * 2, // 2 GB
973973
Category: flags.PortalNetworkCategory,
974974
}
975975

976-
ProtocolUDPListenAddrFlag = &cli.StringFlag{
976+
PortalUDPListenAddrFlag = &cli.StringFlag{
977977
Name: "udp.addr",
978978
Usage: "protocol UDP server listening interface",
979979
Value: "",
980980
Category: flags.PortalNetworkCategory,
981981
}
982982

983-
ProtocolUDPPortFlag = &cli.IntFlag{
983+
PortalUDPPortFlag = &cli.IntFlag{
984984
Name: "udp.port",
985985
Usage: "protocol UDP server listening port",
986986
Value: node.DefaultUDPPort,
987987
Category: flags.PortalNetworkCategory,
988988
}
989989

990-
LogLevelFlag = &cli.IntFlag{
991-
Name: "history.loglevel",
990+
PortalLogLevelFlag = &cli.IntFlag{
991+
Name: "loglevel",
992992
Usage: "loglevel of portal network",
993993
Value: node.DetaultLoglevel,
994994
Category: flags.PortalNetworkCategory,

0 commit comments

Comments
 (0)